MarcoBuster/yt-dlp
1
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-11-24 05:36:56 +01:00
Code Issues Projects Releases Wiki Activity

[EmbedThumbnail] Disable thumbnail conversion for mkv (#3512)

Browse Source 
Closes #3209
Authored by: evansp
This commit is contained in:
Evan Spensley 2022-04-21 17:26:10 -04:00 committed by GitHub
parent 9b8ee23b99
commit 7774db5bf9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
yt_dlp/postprocessor/embedthumbnail.py
View File

@ -79,12 +79,10 @@ def run(self, info):
original_thumbnail = thumbnail_filename = info['thumbnails'][idx]['filepath'] original_thumbnail = thumbnail_filename = info['thumbnails'][idx]['filepath']
# Convert unsupported thumbnail formats to PNG (see #25687, #25717)
# Original behavior was to convert to JPG, but since JPG is a lossy
# format, there will be some additional data loss.
# PNG, on the other hand, is lossless.
thumbnail_ext = os.path.splitext(thumbnail_filename)[1][1:] thumbnail_ext = os.path.splitext(thumbnail_filename)[1][1:]
if thumbnail_ext not in ('jpg', 'jpeg', 'png'): # Convert unsupported thumbnail formats (see #25687, #25717)
# PNG is preferred since JPEG is lossy
if info['ext'] not in ('mkv', 'mka') and thumbnail_ext not in ('jpg', 'jpeg', 'png'):
thumbnail_filename = convertor.convert_thumbnail(thumbnail_filename, 'png') thumbnail_filename = convertor.convert_thumbnail(thumbnail_filename, 'png')
thumbnail_ext = 'png' thumbnail_ext = 'png'
@ -102,7 +100,7 @@ def run(self, info):
elif info['ext'] in ['mkv', 'mka']: elif info['ext'] in ['mkv', 'mka']:
options = list(self.stream_copy_opts()) options = list(self.stream_copy_opts())
mimetype = 'image/%s' % ('png' if thumbnail_ext == 'png' else 'jpeg') mimetype = 'image/%s' % ('jpeg' if thumbnail_ext in ('jpg', 'jpeg') else thumbnail_ext)
old_stream, new_stream = self.get_stream_number( old_stream, new_stream = self.get_stream_number(
filename, ('tags', 'mimetype'), mimetype) filename, ('tags', 'mimetype'), mimetype)
if old_stream is not None: if old_stream is not None: