Appease pyflakes8-3

This commit is contained in:
Philipp Hagemeister 2015-02-01 11:30:56 +01:00
parent 439b9a9e9b
commit 8f9312c387
3 changed files with 27 additions and 20 deletions

View File

@ -25,6 +25,7 @@
import ctypes import ctypes
from .compat import ( from .compat import (
compat_basestring,
compat_cookiejar, compat_cookiejar,
compat_expanduser, compat_expanduser,
compat_http_client, compat_http_client,
@ -1558,7 +1559,7 @@ def urlopen(self, req):
# urllib chokes on URLs with non-ASCII characters (see http://bugs.python.org/issue3991) # urllib chokes on URLs with non-ASCII characters (see http://bugs.python.org/issue3991)
# To work around aforementioned issue we will replace request's original URL with # To work around aforementioned issue we will replace request's original URL with
# percent-encoded one # percent-encoded one
req_is_string = isinstance(req, basestring if sys.version_info < (3, 0) else compat_str) req_is_string = isinstance(req, compat_basestring)
url = req if req_is_string else req.get_full_url() url = req if req_is_string else req.get_full_url()
url_escaped = escape_url(url) url_escaped = escape_url(url)

View File

@ -114,6 +114,26 @@ def compat_urllib_parse_unquote(string, encoding='utf-8', errors='replace'):
string += pct_sequence.decode(encoding, errors) string += pct_sequence.decode(encoding, errors)
return string return string
try:
compat_str = unicode # Python 2
except NameError:
compat_str = str
try:
compat_basestr = basestring # Python 2
except NameError:
compat_basestr = str
try:
compat_chr = unichr # Python 2
except NameError:
compat_chr = chr
try:
from xml.etree.ElementTree import ParseError as compat_xml_parse_error
except ImportError: # Python 2.6
from xml.parsers.expat import ExpatError as compat_xml_parse_error
try: try:
from urllib.parse import parse_qs as compat_parse_qs from urllib.parse import parse_qs as compat_parse_qs
@ -123,7 +143,7 @@ def compat_urllib_parse_unquote(string, encoding='utf-8', errors='replace'):
def _parse_qsl(qs, keep_blank_values=False, strict_parsing=False, def _parse_qsl(qs, keep_blank_values=False, strict_parsing=False,
encoding='utf-8', errors='replace'): encoding='utf-8', errors='replace'):
qs, _coerce_result = qs, unicode qs, _coerce_result = qs, compat_str
pairs = [s2 for s1 in qs.split('&') for s2 in s1.split(';')] pairs = [s2 for s1 in qs.split('&') for s2 in s1.split(';')]
r = [] r = []
for name_value in pairs: for name_value in pairs:
@ -162,21 +182,6 @@ def compat_parse_qs(qs, keep_blank_values=False, strict_parsing=False,
parsed_result[name] = [value] parsed_result[name] = [value]
return parsed_result return parsed_result
try:
compat_str = unicode # Python 2
except NameError:
compat_str = str
try:
compat_chr = unichr # Python 2
except NameError:
compat_chr = chr
try:
from xml.etree.ElementTree import ParseError as compat_xml_parse_error
except ImportError: # Python 2.6
from xml.parsers.expat import ExpatError as compat_xml_parse_error
try: try:
from shlex import quote as shlex_quote from shlex import quote as shlex_quote
except ImportError: # Python < 3.3 except ImportError: # Python < 3.3

View File

@ -32,6 +32,7 @@
import zlib import zlib
from .compat import ( from .compat import (
compat_basestring,
compat_chr, compat_chr,
compat_getenv, compat_getenv,
compat_html_entities, compat_html_entities,
@ -140,7 +141,7 @@ def find_xpath_attr(node, xpath, key, val):
def find_xpath_attr(node, xpath, key, val): def find_xpath_attr(node, xpath, key, val):
# Here comes the crazy part: In 2.6, if the xpath is a unicode, # Here comes the crazy part: In 2.6, if the xpath is a unicode,
# .//node does not match if a node is a direct child of . ! # .//node does not match if a node is a direct child of . !
if isinstance(xpath, unicode): if isinstance(xpath, compat_str):
xpath = xpath.encode('ascii') xpath = xpath.encode('ascii')
for f in node.findall(xpath): for f in node.findall(xpath):
@ -1262,7 +1263,7 @@ def float_or_none(v, scale=1, invscale=1, default=None):
def parse_duration(s): def parse_duration(s):
if not isinstance(s, basestring if sys.version_info < (3, 0) else compat_str): if not isinstance(s, compat_basestring):
return None return None
s = s.strip() s = s.strip()
@ -1426,7 +1427,7 @@ def uppercase_escape(s):
def escape_rfc3986(s): def escape_rfc3986(s):
"""Escape non-ASCII characters as suggested by RFC 3986""" """Escape non-ASCII characters as suggested by RFC 3986"""
if sys.version_info < (3, 0) and isinstance(s, unicode): if sys.version_info < (3, 0) and isinstance(s, compat_str):
s = s.encode('utf-8') s = s.encode('utf-8')
return compat_urllib_parse.quote(s, b"%/;:@&=+$,!~*'()?#[]") return compat_urllib_parse.quote(s, b"%/;:@&=+$,!~*'()?#[]")