From 1452014992340c99d58af624d0a9ce4e29bffb4c Mon Sep 17 00:00:00 2001 From: Connor Tumbleson Date: Thu, 3 Dec 2020 06:21:40 -0500 Subject: [PATCH] fix: early return if no files + enhanced for loop --- brut.j.util/src/main/java/brut/util/OS.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/brut.j.util/src/main/java/brut/util/OS.java b/brut.j.util/src/main/java/brut/util/OS.java index ff7ce7a9..75237277 100644 --- a/brut.j.util/src/main/java/brut/util/OS.java +++ b/brut.j.util/src/main/java/brut/util/OS.java @@ -38,8 +38,11 @@ public class OS { return; } File[] files = dir.listFiles(); - for (int i = 0; i < files.length; i++) { - File file = files[i]; + if (files == null) { + return; + } + + for (File file : files) { if (file.isDirectory()) { rmdir(file); } else { @@ -61,10 +64,12 @@ public class OS { public static void cpdir(File src, File dest) throws BrutException { dest.mkdirs(); File[] files = src.listFiles(); - for (int i = 0; i < files.length; i++) { - File file = files[i]; - File destFile = new File(dest.getPath() + File.separatorChar - + file.getName()); + if (files == null) { + return; + } + + for (File file : files) { + File destFile = new File(dest.getPath() + File.separatorChar + file.getName()); if (file.isDirectory()) { cpdir(file, destFile); continue;