fix: prevent file hold on tmpDir during build (#2745)

This commit is contained in:
Connor Tumbleson 2022-01-18 07:32:41 -05:00 committed by GitHub
parent ddc4bb360a
commit 797fc3e332
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -498,7 +498,8 @@ public class Androlib {
"AndroidManifest.xml"), new File(appDir, "res"), "AndroidManifest.xml"), new File(appDir, "res"),
ninePatch, null, parseUsesFramework(usesFramework)); ninePatch, null, parseUsesFramework(usesFramework));
Directory tmpDir = new ExtFile(apkFile).getDirectory(); ExtFile tmpExtFile = new ExtFile(apkFile);
Directory tmpDir = tmpExtFile.getDirectory();
// Sometimes an application is built with a resources.arsc file with no resources, // Sometimes an application is built with a resources.arsc file with no resources,
// Apktool assumes it will have a rebuilt arsc file, when it doesn't. So if we // Apktool assumes it will have a rebuilt arsc file, when it doesn't. So if we
@ -509,6 +510,8 @@ public class Androlib {
: APK_RESOURCES_WITHOUT_RES_FILENAMES); : APK_RESOURCES_WITHOUT_RES_FILENAMES);
} catch (DirectoryException ex) { } catch (DirectoryException ex) {
LOGGER.warning(ex.getMessage()); LOGGER.warning(ex.getMessage());
} finally {
tmpExtFile.close();
} }
// delete tmpDir // delete tmpDir