From 7b3e5a166890367deb755a89872b817295b3d450 Mon Sep 17 00:00:00 2001 From: Ben Gruver Date: Wed, 18 Mar 2015 20:13:02 -0700 Subject: [PATCH] Don't wrap a large (>32k) register count in a register directive --- .../org/jf/baksmali/ManyRegistersTest.java | 42 +++++++++++++++++++ .../ManyRegistersTest/ManyRegisters.smali | 7 ++++ .../smali/src/main/antlr/smaliTreeWalker.g | 2 +- 3 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 brut.apktool.smali/baksmali/src/test/java/org/jf/baksmali/ManyRegistersTest.java create mode 100644 brut.apktool.smali/baksmali/src/test/resources/ManyRegistersTest/ManyRegisters.smali diff --git a/brut.apktool.smali/baksmali/src/test/java/org/jf/baksmali/ManyRegistersTest.java b/brut.apktool.smali/baksmali/src/test/java/org/jf/baksmali/ManyRegistersTest.java new file mode 100644 index 00000000..5a267161 --- /dev/null +++ b/brut.apktool.smali/baksmali/src/test/java/org/jf/baksmali/ManyRegistersTest.java @@ -0,0 +1,42 @@ +/* + * Copyright 2015, Google Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +package org.jf.baksmali; + +import org.junit.Test; + +public class ManyRegistersTest extends IdenticalRoundtripTest { + + @Test + public void testManyRegisters() { + runTest("ManyRegisters"); + } +} diff --git a/brut.apktool.smali/baksmali/src/test/resources/ManyRegistersTest/ManyRegisters.smali b/brut.apktool.smali/baksmali/src/test/resources/ManyRegistersTest/ManyRegisters.smali new file mode 100644 index 00000000..7f7c7bb1 --- /dev/null +++ b/brut.apktool.smali/baksmali/src/test/resources/ManyRegistersTest/ManyRegisters.smali @@ -0,0 +1,7 @@ +.class LManyRegisters; +.super Ljava/lang/Object; + +.method public manyRegisters()V + .registers 65535 + return-void +.end method \ No newline at end of file diff --git a/brut.apktool.smali/smali/src/main/antlr/smaliTreeWalker.g b/brut.apktool.smali/smali/src/main/antlr/smaliTreeWalker.g index d319b2ca..8eed2b20 100644 --- a/brut.apktool.smali/smali/src/main/antlr/smaliTreeWalker.g +++ b/brut.apktool.smali/smali/src/main/antlr/smaliTreeWalker.g @@ -532,7 +532,7 @@ registers_directive returns[boolean isLocalsDirective, int registers] ^(( I_REGISTERS {$isLocalsDirective = false;} | I_LOCALS {$isLocalsDirective = true;} ) - short_integral_literal {$registers = $short_integral_literal.value;} + short_integral_literal {$registers = $short_integral_literal.value & 0xFFFF;} ); label_def