From 856cc2822c8a3adb1c8189aa320e4f6013d5ec8f Mon Sep 17 00:00:00 2001 From: Connor Tumbleson Date: Sun, 9 Jul 2017 10:55:57 -0400 Subject: [PATCH] Prevent license checks from running - update internal docs to explain license tasks --- INTERNAL.md | 16 +++++++++++++++- build.gradle | 10 ++++------ 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/INTERNAL.md b/INTERNAL.md index 57ea9cd0..996a81a5 100644 --- a/INTERNAL.md +++ b/INTERNAL.md @@ -2,7 +2,21 @@ The steps taken for slicing an official release of Apktool. -### Taging the release. +### Ensuring proper license headers + +Before we build a release, its a good practice to ensure all headers in source files contain +proper licenses. + + ./gradlew licenseMain && ./gradlew licenseTest + +If any license violations were found you can automatically fix them with either + + ./gradlew licenseFormatMain + ./gradlew licenseFormatTest + +Like described, one formats the `src/main` directory, while the other formats the `src/test` directory. + +### Tagging the release. Inside `build.gradle` there are two lines. diff --git a/build.gradle b/build.gradle index 5d4833b4..1952f5d5 100644 --- a/build.gradle +++ b/build.gradle @@ -57,8 +57,10 @@ allprojects { tasks.withType(JavaCompile) { options.compilerArgs += ["-Xlint:-options"] } - compileJava.finalizedBy licenseFormatMain - licenseFormatMain.finalizedBy licenseFormatTest + + // license plugin automatically fires these tasks, disable them and run them during releases + gradle.startParameter.excludedTaskNames += "licenseMain" + gradle.startParameter.excludedTaskNames += "licenseTest" } if (!('release' in gradle.startParameter.taskNames)) { @@ -123,10 +125,6 @@ subprojects { mavenCentral() } - dependencies { - testCompile depends.junit - } - test { testLogging { exceptionFormat = 'full'