From 93c95067085758083d99617361cd59942ac9b1a8 Mon Sep 17 00:00:00 2001 From: Mieras Made Date: Sun, 9 Sep 2018 20:22:39 +0200 Subject: [PATCH] #84 PackageManager problems: Fixes issue 1 & 2 - after review --- .../jadb/managers/PackageManager.java | 6 ++--- .../jadb/test/unit/PackageManagerTest.java | 24 ------------------- 2 files changed, 3 insertions(+), 27 deletions(-) diff --git a/src/se/vidstige/jadb/managers/PackageManager.java b/src/se/vidstige/jadb/managers/PackageManager.java index df777f2..8609fd8 100644 --- a/src/se/vidstige/jadb/managers/PackageManager.java +++ b/src/se/vidstige/jadb/managers/PackageManager.java @@ -94,10 +94,10 @@ public class PackageManager { private final StringBuilder stringBuilder = new StringBuilder(); InstallOption(String ... varargs) { - String space = ""; + String suffix = ""; for(String str: varargs) { - stringBuilder.append(space).append(str); - space = " "; + stringBuilder.append(suffix).append(str); + suffix = " "; } } diff --git a/test/se/vidstige/jadb/test/unit/PackageManagerTest.java b/test/se/vidstige/jadb/test/unit/PackageManagerTest.java index e1275cf..c21d0ab 100644 --- a/test/se/vidstige/jadb/test/unit/PackageManagerTest.java +++ b/test/se/vidstige/jadb/test/unit/PackageManagerTest.java @@ -9,7 +9,6 @@ import se.vidstige.jadb.managers.Package; import se.vidstige.jadb.managers.PackageManager; import se.vidstige.jadb.test.fakes.FakeAdbServer; -import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; @@ -91,27 +90,4 @@ public class PackageManagerTest { //Assert assertEquals(expected, actual); } - - @Test - public void testWithForwardLock() throws Exception { - PackageManager.InstallOption withForwardLock = PackageManager.WITH_FORWARD_LOCK; - // Letter L not number 1 - String expected = "-l"; - Method privateMethod = withForwardLock.getClass().getDeclaredMethod("getStringRepresentation"); - privateMethod.setAccessible(true); - String actual = (String) privateMethod.invoke(withForwardLock); - - assertEquals(expected, actual); - } - - @Test - public void testWithInstallerPackageName() throws Exception { - PackageManager.InstallOption withInstallerPackageName = PackageManager.WITH_INSTALLER_PACKAGE_NAME("aaa bbb"); - String expected = "-t aaa bbb"; - Method privateMethod = withInstallerPackageName.getClass().getDeclaredMethod("getStringRepresentation"); - privateMethod.setAccessible(true); - String actual = (String) privateMethod.invoke(withInstallerPackageName); - - assertEquals(expected, actual); - } } \ No newline at end of file