diff --git a/src/se/vidstige/jadb/managers/PackageManager.java b/src/se/vidstige/jadb/managers/PackageManager.java index 5d7ed02..40d0fde 100644 --- a/src/se/vidstige/jadb/managers/PackageManager.java +++ b/src/se/vidstige/jadb/managers/PackageManager.java @@ -22,10 +22,8 @@ public class PackageManager { } public List getPackages() throws IOException, JadbException { - ArrayList result = new ArrayList<>(); - BufferedReader input = null; - try { - input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8)); + try (BufferedReader input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8))) { + ArrayList result = new ArrayList<>(); String line; while ((line = input.readLine()) != null) { final String prefix = "package:"; @@ -33,10 +31,8 @@ public class PackageManager { result.add(new Package(line.substring(prefix.length()))); } } - } finally { - if (input != null) input.close(); + return result; } - return result; } private String getErrorMessage(String operation, String target, String errorMessage) {