Performance: Make inner classes static

This commit is contained in:
Jano Svitok 2018-08-06 12:53:03 +02:00
parent 71689e4757
commit fef9997edf
4 changed files with 6 additions and 6 deletions

View File

@ -91,7 +91,7 @@ public class FakeAdbServer implements AdbResponder {
return new ArrayList<AdbDeviceResponder>(devices);
}
private class DeviceResponder implements AdbDeviceResponder {
private static class DeviceResponder implements AdbDeviceResponder {
private final String serial;
private final String type;
private List<FileExpectation> fileExpectations = new ArrayList<FileExpectation>();
@ -155,7 +155,7 @@ public class FakeAdbServer implements AdbResponder {
org.junit.Assert.assertEquals(0, shellExpectations.size());
}
private class FileExpectation implements ExpectationBuilder {
private static class FileExpectation implements ExpectationBuilder {
private final RemoteFile path;
private byte[] content;
private String failMessage;
@ -199,7 +199,7 @@ public class FakeAdbServer implements AdbResponder {
}
}
public class ShellExpectation {
public static class ShellExpectation {
private final String command;
private byte[] stdout;

View File

@ -48,7 +48,7 @@ public class FakeSubprocess extends Subprocess {
}
}
private class Expectation {
private static class Expectation {
private final String[] command;
private final int exitValue;

View File

@ -15,7 +15,7 @@ import java.util.List;
import static org.junit.Assert.assertEquals;
public class PackageManagerTest {
private final String DEVICE_SERIAL = "serial-123";
private static final String DEVICE_SERIAL = "serial-123";
private FakeAdbServer server;
private JadbConnection connection;

View File

@ -14,7 +14,7 @@ import java.util.Map;
import static org.junit.Assert.assertEquals;
public class PropertyManagerTest {
private final String DEVICE_SERIAL = "serial-123";
private static final String DEVICE_SERIAL = "serial-123";
private FakeAdbServer server;
private JadbConnection connection;