Commit Graph

165 Commits

Author SHA1 Message Date
Jano Svitok
188aec84d6 Fix: Return of boolean expressions should not be wrapped into an "if-then-else" statement (squid:S1126) 2018-07-30 13:38:35 +02:00
Jano Svitok
1a34d13bbb Fix: Empty statements should be removed (squid:EmptyStatementUsageCheck) 2018-07-30 13:38:24 +02:00
Jano Svitok
9b4be76f3e Fix: Local variable and method parameter names should comply with a naming convention (squid:S00117) 2018-07-30 13:38:07 +02:00
Jano Svitok
aa245626ab Suppress: Method names should comply with a naming convention (squid:S00100) 2018-07-30 13:37:55 +02:00
Jano Svitok
f40d46917b Fix: The diamond operator ("<>") should be used (squid:S2293) 2018-07-30 13:37:45 +02:00
Jano Svitok
17b93cb935 Suppress: Constant names should comply with a naming convention (squid:S00115) 2018-07-30 13:37:37 +02:00
Jano Svitok
70c700a6a1 Fix: Modifiers should be declared in the correct order (squid:ModifiersOrderCheck) 2018-07-30 13:37:23 +02:00
Jano Svitok
c40420a64a Fix Loops should not be infinite (squid:S2189) - suppress this check 2018-07-30 13:37:08 +02:00
Jano Svitok
f7a72e556c Fix typo 2018-05-22 16:37:53 +02:00
anthonyflynn
23bfd4bf7d Simplifying equals method and changing class check to use instanceof. 2018-02-04 19:55:02 +00:00
anthonyflynn
1834bc4812 Comparing attribute equality for equals method (reflecting RemoveFile class). 2018-02-03 19:11:42 +00:00
Muhammad Ikhsan
e441c96c85 Check other whitespace characters, e.g. tabs 2017-10-17 16:29:40 +07:00
ErnyTech Team
edbf822c65 Update JadbDevice.java
Repair format
2017-10-12 09:49:31 +02:00
ErnyTech Team
1aebcaee1d Add recovery state supoort 2017-10-08 17:08:56 +02:00
Samuel Carlsson
2775691d70 Merge pull request #60 from tmyroadctfig/master
Allow the location of the ADB binary to be specified for AdbServerLauncher.
2017-03-30 19:47:46 +02:00
Luke Quinane
62ae7cf530 Allow the location of the ADB binary to be specified. 2017-03-30 11:10:51 +11:00
Art
4442663889 #58 migration to InetSocketAddress 2017-03-20 15:17:38 +03:00
Art
64544b5bff #58 fixes in spaces and newline at the end of new files. Fixed typo in test 2017-03-20 14:48:09 +03:00
Art
0a12f784ca #58 implemented disconnect command 2017-03-20 13:48:24 +03:00
Art
f6e7da4f1f #58 connect command implemented and it`s test 2017-03-20 13:18:56 +03:00
Art
ebbceb99d5 #58 skeleton implemented 2017-03-17 19:48:13 +03:00
Luke Quinane
0d1d326845 Add executeShellRaw() command using adb 'exec'. Code review changes. 2017-03-13 10:22:13 +11:00
Luke Quinane
ccd20658f1 Add executeShellRaw() command using adb 'exec'. 2017-02-02 13:43:03 +11:00
Jari Hämäläinen
d3ef914b43 Use try-with-resources to close PropertyManager's reader 2017-01-30 20:50:34 +02:00
Jari Hämäläinen
8115621587 Close PropertyManager's reader after parsing 2017-01-28 16:57:30 +02:00
Jari Hämäläinen
a083481f4a PropertyManager's pattern only needs to be compiled once
According to Pattern docs "Instances of this class are immutable and are
safe for use by multiple concurrent threads."
2017-01-28 16:54:51 +02:00
Jari Hämäläinen
206b9c4352 Allow any character except square brackets in property values
PropertyManager failed to get all properties from certain devices
because it allowed only [a-zA-Z0-9_.-] characters in values but
they can contain other characters too. For example in Nexus 9
ro.product.model is "Nexus 9" (has space).

This commit changes allowed characters in property value to contain
anything except square brackets.
2017-01-28 16:53:13 +02:00
Giemsa
d1af94d257 minor changes to some API 2016-12-12 08:49:30 +01:00
Daniel Friederich
b4f5083d00 Change AdbFilterInputStream.read not to wait for more data
The previous AdbFilterInputStream.read function was always waiting for
buffer to fill, even if this meant to block for a long time. Now it checks
if the next read will block. The one case it still could block, when
reading a 0xd (carriage return) is not expected to occur for interactive
output (at least as the last character of some input).
This removes the need for a separate executeShellRaw method.
2016-11-07 09:42:06 +01:00
Daniel Friederich
f8c9098a7e minor changes to address warnings, etc 2016-11-07 09:42:06 +01:00
Daniel Friederich
22f2442731 Add executeShellRaw method. Avoids buffering issues
The buffering used in executeShell causes issues when using shell:logcat,
the character per character implementation of the InputStream handling in AdbFilterInputStream together with the BufferedInputStream class
cause that the caller only gets result once either the process ends or 8k of output is avilable. The executeShellRaw method bypasses
the custom buffer handling, allowing the caller to receive the output without delay.
Note that the issue is only apparent when using a long running commamd with little output.
2016-11-07 09:42:06 +01:00
Giemsa
86ccd4ab42 add unit test for getState 2016-10-26 21:10:26 +02:00
Giemsa
4486bd0a7a remove Thread 2016-10-26 21:10:26 +02:00
Giemsa
706c64d36f change class name 2016-10-26 21:10:26 +02:00
Giemsa
abbd2ad228 change var name 2016-10-26 21:10:26 +02:00
Giemsa
46a91334e0 change method name 2016-10-26 21:10:26 +02:00
Giemsa
b50590f411 close transport 2016-10-26 21:10:26 +02:00
Giemsa
af7b8ec5ab refactoring 2016-10-26 21:10:26 +02:00
Giemsa
76c9045b0c get state by get-state command 2016-10-26 21:10:26 +02:00
Giemsa
e324cbe004 indentation 2016-10-26 21:10:26 +02:00
Giemsa
fe744a007b typo 2016-10-26 21:10:26 +02:00
Giemsa
7a249c3476 device detection 2016-10-26 21:10:26 +02:00
Samuel Carlsson
70ea021bf0 Merge pull request #39 from SKART1/IMP-38-getprop
Imp 38 getprop
2016-10-03 17:57:17 +02:00
Arthur
f4c44d6e3f vidstige/jadb#38 pull-request fixes 2016-10-03 14:04:49 +03:00
Samuel Carlsson
5b66a90c3b Refactor: Adding dummy test for getprop function.
- The FakeServer can now return a string as stdout.
2016-10-03 13:36:00 +03:00
Samuel Carlsson
24348f806d Refactor: Better names
- serverReady and waitForServer had inverted names for some reason.
2016-10-01 16:36:14 +02:00
Samuel Carlsson
2073817c95 Refactor: Adding dummy test for getprop function.
- The FakeServer can now return a string as stdout.
2016-10-01 16:36:06 +02:00
Arthur
9c83f0320c vidstige/jadb#38 added unit tests 2016-09-30 18:30:28 +03:00
Arthur
02f6f6d79d vidstige/jadb#38 skeleton implemented. Need unit-tests 2016-09-30 15:14:02 +03:00
Samuel Carlsson
58a370928e Refactor: Adding unit test for AdbServerLauncher 2016-09-10 09:13:29 +02:00
Samuel Carlsson
c2acf534ff Refactor: Moving out methods for clarity. 2016-08-02 21:52:34 +02:00
Samuel Carlsson
ce6f04bdc7 Fixing a race condition in socket server
- This caused the mocked test cases to sometimes hang.
- Was particularly noticeable when running with code coverage.
2016-08-02 20:32:59 +02:00
Samuel Carlsson
72c632001e Refactor: Renaming to InstallOption
Removing plural to keep things clear.
2016-08-01 19:45:50 +02:00
Samuel Carlsson
9b8ba8ff52 Refactor: Using functions/fields instead of classes.
Cleaning up PackageManager.
2016-08-01 19:45:49 +02:00
Arthur
983dedf706 vidstige/jadb#17 adding options for pm install command 2016-07-26 13:06:46 +03:00
Samuel Carlsson
22b6e8e03f Removing getState, which was not working properly.
Tried to fix, by following the documentation found at https://github.com/android/platform_system_core/blob/master/adb/SERVICES.TXT, but to no avail.
2016-07-22 16:06:55 +02:00
Samuel Carlsson
2b71a04b4c Refactor: Cleaning up forceInstall 2016-05-13 21:40:14 +02:00
fashioncj
71388516fe fix whitespace 2016-05-08 14:43:53 +08:00
fashioncj
c52447e098 add forceInstall for application already exist
add a way to remove installed apk

fix issue
2016-05-08 14:38:01 +08:00
fashioncj
639ecdb633 add forceInstall for application already exist
add a way to remove installed apk
2016-05-05 21:36:42 +08:00
Samuel Carlsson
cadf3d4957 Quoting shell arguments with spaces 2016-04-29 15:02:18 +02:00
Samuel Carlsson
07f74cb20a Now possible to launch apps by package name 2016-04-29 10:02:55 +02:00
Samuel Carlsson
a1e55f06d8 Now possible to install packages easily. 2016-04-28 13:51:08 +02:00
Samuel Carlsson
dfb04af94b Adding package manager 2016-04-27 21:56:12 +02:00
Samuel Carlsson
0d60b34e7e Depricating the old executeShell method. 2016-04-27 20:39:14 +02:00
Samuel Carlsson
8cee1088a8 The shell command now returns InputStream. 2016-04-27 20:39:14 +02:00
Samuel Carlsson
6c1835cc11 Automatically tries to launch adb server.
Fixes issue #3.
2016-03-28 21:09:00 +02:00
Samuel Carlsson
68e92d14f4 Filtering out 0x0d, 0x0a sequences from shell commands. Makes screenshotting work again. :-) 2016-03-28 14:01:17 +02:00
Samuel Carlsson
c9a0a59ace Filtering out 0x0d, 0x0a sequences from shell commands. Makes screenshotting work again. :-) 2016-03-28 09:41:53 +02:00
Samuel Carlsson
41872e3bb9 Refactor: Consistent whitespace & brace style 2016-03-20 09:13:59 +01:00
Samuel Carlsson
d716ba0325 Using UnsupportedOperationException instead of weird NotImplementedException 2016-03-15 09:12:43 +01:00
Samuel Carlsson
84950ceadb Refactor: Avoids having stale transport lingering around. 2016-03-02 21:14:32 +01:00
Samuel Carlsson
92506f643d Using streams rather than byte arrays. 2016-03-02 21:06:19 +01:00
Gergő Törcsvári
27bed5a88a fix (codeorg): small code cleanup
fix (test): bugfix
2016-03-02 00:10:05 +01:00
Gergő Törcsvári
722ecc4f8b bytearray shell execution added 2016-02-28 10:54:33 +01:00
Gergő Törcsvári
5ab126ddbe reuseable jadbDevices and the shell command returns a string 2016-02-28 03:04:59 +01:00
Samuel Carlsson
31456f7a36 Refactor: Fixing some code issues found by IntelliJ 2014-07-25 19:51:57 +02:00
Samuel Carlsson
a58587f794 Adding test case for pulling file. 2014-03-26 22:12:29 +01:00
Samuel Carlsson
39ea2d92d6 Adding test for pushing to invalid path. 2014-03-26 21:46:21 +01:00
Samuel Carlsson
ee239467d0 Now actually asserting that non expected pushes are not sent. 2014-03-26 10:07:24 +01:00
Samuel Carlsson
89403cb126 Adding callback for file pushed. 2014-03-25 15:52:32 +01:00
Samuel Carlsson
0e94c45791 Adding mocked unit test for pushing file. 2014-03-25 15:46:54 +01:00
Samuel Carlsson
25745857b7 Refactor: Using exceptions to send errors back to client in mocked server. 2014-03-24 21:06:47 +01:00
Samuel Carlsson
c051da8e7f Fixing a problem where errors during pull where not handled correctly. 2014-03-20 21:31:25 +01:00
Samuel Carlsson
5f54c813cc Adding pull and push methods that take streams rather than local files for more flexibility and easier testing. 2014-03-20 21:23:08 +01:00
Samuel Carlsson
fa74fd88bd Fixing a bug where jadb would hang if no devices where found. 2014-03-20 17:30:21 +01:00
Samuel Carlsson
59cc2e9d1e Refactor: Now expected serial is stated in the test for added clarity. 2014-03-20 17:22:05 +01:00
Samuel Carlsson
aecd17a446 Refactor: Moving server code into Jadb from the test package. 2014-03-20 17:01:56 +01:00
Samuel Carlsson
e26de967bf Refactor: Making RemoteFileRecord package local. 2014-03-20 11:38:50 +01:00
Samuel Carlsson
29c3a3956a Using strong types File and RemoteFile in public arguments where appropriate. 2014-03-20 11:37:04 +01:00
Samuel Carlsson
ac47d49cc7 Refactor: Creating RemoteFile base class to be used as arguments. 2014-03-20 11:33:03 +01:00
Samuel Carlsson
dbe57d0279 Refactor: Fixing warnings 2014-03-20 10:35:08 +01:00
Samuel Carlsson
88faded23d Adding truly mocked test case. 2014-03-20 10:31:13 +01:00
Samuel Carlsson
fef216f3ce Adding support for pulling files from device 2014-03-20 10:10:35 +01:00
Samuel Carlsson
e09b429b86 Refactor: Renaming to JadbDevice. 2014-03-20 09:50:17 +01:00
Samuel Carlsson
15f49dde6a Refactor: Extracting method. 2014-03-19 21:18:03 +01:00
Samuel Carlsson
de0c65d922 Adding support for pushing files to device. 2014-03-19 21:15:40 +01:00
Samuel Carlsson
6b8c330195 Fixing a bug where strings where sometimes not read completely during sync. Removing some IntellJ warnings. 2014-03-19 17:36:53 +01:00
Samuel Carlsson
0bc737adab Made the list method return the files rather than print them on stdout 2014-03-19 17:19:05 +01:00
Samuel Carlsson
d456c1d79a Refactor: Renaming to RemoteFile to better match the java api 2014-03-19 16:56:38 +01:00