diff --git a/app/src/main/java/app/revanced/integrations/all/screencapture/removerestriction/RemoveScreencaptureRestrictionPatch.java b/app/src/main/java/app/revanced/integrations/all/screencapture/removerestriction/RemoveScreencaptureRestrictionPatch.java index c76d395d..f4e4739b 100644 --- a/app/src/main/java/app/revanced/integrations/all/screencapture/removerestriction/RemoveScreencaptureRestrictionPatch.java +++ b/app/src/main/java/app/revanced/integrations/all/screencapture/removerestriction/RemoveScreencaptureRestrictionPatch.java @@ -5,6 +5,7 @@ import android.os.Build; import androidx.annotation.RequiresApi; +@SuppressWarnings("unused") public final class RemoveScreencaptureRestrictionPatch { // Member of AudioAttributes.Builder @RequiresApi(api = Build.VERSION_CODES.Q) diff --git a/app/src/main/java/app/revanced/integrations/all/screenshot/removerestriction/RemoveScreenshotRestrictionPatch.java b/app/src/main/java/app/revanced/integrations/all/screenshot/removerestriction/RemoveScreenshotRestrictionPatch.java index d2ebeb87..710bb195 100644 --- a/app/src/main/java/app/revanced/integrations/all/screenshot/removerestriction/RemoveScreenshotRestrictionPatch.java +++ b/app/src/main/java/app/revanced/integrations/all/screenshot/removerestriction/RemoveScreenshotRestrictionPatch.java @@ -3,6 +3,7 @@ package app.revanced.integrations.all.screenshot.removerestriction; import android.view.Window; import android.view.WindowManager; +@SuppressWarnings("unused") public class RemoveScreenshotRestrictionPatch { public static void addFlags(Window window, int flags) { diff --git a/app/src/main/java/app/revanced/integrations/reddit/patches/FilterPromotedLinksPatch.java b/app/src/main/java/app/revanced/integrations/reddit/patches/FilterPromotedLinksPatch.java index de8469e2..6a97712e 100644 --- a/app/src/main/java/app/revanced/integrations/reddit/patches/FilterPromotedLinksPatch.java +++ b/app/src/main/java/app/revanced/integrations/reddit/patches/FilterPromotedLinksPatch.java @@ -5,8 +5,12 @@ import com.reddit.domain.model.ILink; import java.util.ArrayList; import java.util.List; +@SuppressWarnings("unused") public final class FilterPromotedLinksPatch { + /** + * Injection point. + * * Filters list from promoted links. **/ public static List filterChildren(final Iterable links) { diff --git a/app/src/main/java/app/revanced/integrations/shared/GmsCoreSupport.java b/app/src/main/java/app/revanced/integrations/shared/GmsCoreSupport.java index 16f0ed0c..e9dee1a5 100644 --- a/app/src/main/java/app/revanced/integrations/shared/GmsCoreSupport.java +++ b/app/src/main/java/app/revanced/integrations/shared/GmsCoreSupport.java @@ -138,7 +138,11 @@ public class GmsCoreSupport { } } - // Modified by a patch. Do not touch. + /** + * Modified by a patch. Do not touch. + * + * @noinspection SameReturnValue + */ private static String getGmsCoreVendorGroupId() { return "app.revanced"; } diff --git a/app/src/main/java/app/revanced/integrations/shared/Utils.java b/app/src/main/java/app/revanced/integrations/shared/Utils.java index bdad852f..bacef1b5 100644 --- a/app/src/main/java/app/revanced/integrations/shared/Utils.java +++ b/app/src/main/java/app/revanced/integrations/shared/Utils.java @@ -52,6 +52,7 @@ public class Utils { * Injection point. * * @return The manifest 'Version' entry of the patches.jar used during patching. + * @noinspection SameReturnValue */ public static String getPatchesReleaseVersion() { return ""; // Value is replaced during patching. diff --git a/app/src/main/java/app/revanced/integrations/syncforreddit/FixSLinksPatch.java b/app/src/main/java/app/revanced/integrations/syncforreddit/FixSLinksPatch.java index a3c04ad6..8acd4b99 100644 --- a/app/src/main/java/app/revanced/integrations/syncforreddit/FixSLinksPatch.java +++ b/app/src/main/java/app/revanced/integrations/syncforreddit/FixSLinksPatch.java @@ -6,7 +6,12 @@ import app.revanced.integrations.shared.Logger; import java.net.HttpURLConnection; import java.net.URL; +@SuppressWarnings("unused") public final class FixSLinksPatch { + + /** + * Injection point. + */ public static String resolveSLink(String link) { if (link.matches(".*reddit\\.com/r/[^/]+/s/[^/]+")) { Logger.printInfo(() -> "Resolving " + link); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/AdsFilter.java b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/AdsFilter.java index c246e622..20a99aae 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/AdsFilter.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/AdsFilter.java @@ -3,6 +3,7 @@ package app.revanced.integrations.tiktok.feedfilter; import app.revanced.integrations.tiktok.settings.Settings; import com.ss.android.ugc.aweme.feed.model.Aweme; +/** @noinspection unused*/ public class AdsFilter implements IFilter { @Override public boolean getEnabled() { diff --git a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/FeedItemsFilter.java b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/FeedItemsFilter.java index d74ea59e..d84bb2ca 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/FeedItemsFilter.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/FeedItemsFilter.java @@ -6,6 +6,7 @@ import com.ss.android.ugc.aweme.feed.model.FeedItemList; import java.util.Iterator; import java.util.List; +@SuppressWarnings("unused") public final class FeedItemsFilter { private static final List FILTERS = List.of( new AdsFilter(), @@ -16,6 +17,9 @@ public final class FeedItemsFilter { new LikeCountFilter() ); + /** + * Injection point. + */ public static void filter(FeedItemList feedItemList) { Iterator feedItemListIterator = feedItemList.items.iterator(); while (feedItemListIterator.hasNext()) { diff --git a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/ImageVideoFilter.java b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/ImageVideoFilter.java index 50472197..a0616cce 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/ImageVideoFilter.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/ImageVideoFilter.java @@ -3,6 +3,7 @@ package app.revanced.integrations.tiktok.feedfilter; import app.revanced.integrations.tiktok.settings.Settings; import com.ss.android.ugc.aweme.feed.model.Aweme; +@SuppressWarnings("unused") public class ImageVideoFilter implements IFilter { @Override public boolean getEnabled() { diff --git a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/LiveFilter.java b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/LiveFilter.java index bec7f11c..27fa8b1b 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/LiveFilter.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/feedfilter/LiveFilter.java @@ -3,6 +3,7 @@ package app.revanced.integrations.tiktok.feedfilter; import app.revanced.integrations.tiktok.settings.Settings; import com.ss.android.ugc.aweme.feed.model.Aweme; +@SuppressWarnings("unused") public class LiveFilter implements IFilter { @Override public boolean getEnabled() { diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/SettingsStatus.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/SettingsStatus.java index 81c74be4..519a776a 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/SettingsStatus.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/SettingsStatus.java @@ -1,5 +1,6 @@ package app.revanced.integrations.tiktok.settings; +@SuppressWarnings("unused") public class SettingsStatus { public static boolean feedFilterEnabled = false; public static boolean downloadEnabled = false; @@ -17,6 +18,7 @@ public class SettingsStatus { simSpoofEnabled = true; } + /** @noinspection EmptyMethod*/ public static void load() { } diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/ReVancedPreferenceFragment.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/ReVancedPreferenceFragment.java index 66359350..4b981eca 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/ReVancedPreferenceFragment.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/ReVancedPreferenceFragment.java @@ -14,7 +14,7 @@ import org.jetbrains.annotations.NotNull; /** * Preference fragment for ReVanced settings */ -@SuppressWarnings("deprecation") +@SuppressWarnings({"deprecation", "unused"}) public class ReVancedPreferenceFragment extends AbstractPreferenceFragment { @Override @@ -33,6 +33,7 @@ public class ReVancedPreferenceFragment extends AbstractPreferenceFragment { } @Override + @SuppressWarnings("unused") protected void initialize() { final var context = getContext(); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/ConditionalPreferenceCategory.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/ConditionalPreferenceCategory.java index 24eaa1e9..9f85c3f7 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/ConditionalPreferenceCategory.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/ConditionalPreferenceCategory.java @@ -4,7 +4,7 @@ import android.content.Context; import android.preference.PreferenceCategory; import android.preference.PreferenceScreen; -@SuppressWarnings("deprecation") +@SuppressWarnings({"deprecation", "unused"}) public abstract class ConditionalPreferenceCategory extends PreferenceCategory { public ConditionalPreferenceCategory(Context context, PreferenceScreen screen) { super(context); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/DownloadsPreferenceCategory.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/DownloadsPreferenceCategory.java index 8ecbfb36..1bf0f6d6 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/DownloadsPreferenceCategory.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/DownloadsPreferenceCategory.java @@ -7,7 +7,7 @@ import app.revanced.integrations.tiktok.settings.SettingsStatus; import app.revanced.integrations.tiktok.settings.preference.DownloadPathPreference; import app.revanced.integrations.tiktok.settings.preference.TogglePreference; -@SuppressWarnings("deprecation") +@SuppressWarnings({"deprecation", "unused"}) public class DownloadsPreferenceCategory extends ConditionalPreferenceCategory { public DownloadsPreferenceCategory(Context context, PreferenceScreen screen) { super(context, screen); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/FeedFilterPreferenceCategory.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/FeedFilterPreferenceCategory.java index 5bb40a2e..98d71855 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/FeedFilterPreferenceCategory.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/FeedFilterPreferenceCategory.java @@ -7,7 +7,7 @@ import app.revanced.integrations.tiktok.settings.Settings; import app.revanced.integrations.tiktok.settings.SettingsStatus; import app.revanced.integrations.tiktok.settings.preference.TogglePreference; -@SuppressWarnings("deprecation") +@SuppressWarnings({"deprecation", "unused"}) public class FeedFilterPreferenceCategory extends ConditionalPreferenceCategory { public FeedFilterPreferenceCategory(Context context, PreferenceScreen screen) { super(context, screen); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/IntegrationsPreferenceCategory.java b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/IntegrationsPreferenceCategory.java index 96e6e892..ec53d5f1 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/IntegrationsPreferenceCategory.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/settings/preference/categories/IntegrationsPreferenceCategory.java @@ -6,7 +6,7 @@ import android.preference.PreferenceScreen; import app.revanced.integrations.shared.settings.BaseSettings; import app.revanced.integrations.tiktok.settings.preference.TogglePreference; -@SuppressWarnings("deprecation") +@SuppressWarnings({"deprecation", "unused"}) public class IntegrationsPreferenceCategory extends ConditionalPreferenceCategory { public IntegrationsPreferenceCategory(Context context, PreferenceScreen screen) { super(context, screen); diff --git a/app/src/main/java/app/revanced/integrations/tiktok/speed/PlaybackSpeedPatch.java b/app/src/main/java/app/revanced/integrations/tiktok/speed/PlaybackSpeedPatch.java index 1681ad0c..c5d15d78 100644 --- a/app/src/main/java/app/revanced/integrations/tiktok/speed/PlaybackSpeedPatch.java +++ b/app/src/main/java/app/revanced/integrations/tiktok/speed/PlaybackSpeedPatch.java @@ -2,7 +2,9 @@ package app.revanced.integrations.tiktok.speed; import app.revanced.integrations.tiktok.settings.Settings; +@SuppressWarnings("unused") public class PlaybackSpeedPatch { + public static void rememberPlaybackSpeed(float newSpeed) { Settings.REMEMBERED_SPEED.save(newSpeed); } diff --git a/app/src/main/java/app/revanced/integrations/twitch/settings/preference/CustomPreferenceCategory.java b/app/src/main/java/app/revanced/integrations/twitch/settings/preference/CustomPreferenceCategory.java index 64f0a3d8..a3238ded 100644 --- a/app/src/main/java/app/revanced/integrations/twitch/settings/preference/CustomPreferenceCategory.java +++ b/app/src/main/java/app/revanced/integrations/twitch/settings/preference/CustomPreferenceCategory.java @@ -7,6 +7,7 @@ import android.util.AttributeSet; import android.view.View; import android.widget.TextView; +/** @noinspection unused*/ public class CustomPreferenceCategory extends PreferenceCategory { public CustomPreferenceCategory(Context context, AttributeSet attrs) { super(context, attrs); diff --git a/app/src/main/java/app/revanced/integrations/twitch/settings/preference/ReVancedPreferenceFragment.java b/app/src/main/java/app/revanced/integrations/twitch/settings/preference/ReVancedPreferenceFragment.java index 1d3cca4b..39fb5f07 100644 --- a/app/src/main/java/app/revanced/integrations/twitch/settings/preference/ReVancedPreferenceFragment.java +++ b/app/src/main/java/app/revanced/integrations/twitch/settings/preference/ReVancedPreferenceFragment.java @@ -10,6 +10,7 @@ import app.revanced.integrations.twitch.settings.Settings; public class ReVancedPreferenceFragment extends AbstractPreferenceFragment { @Override + @SuppressWarnings("unused") protected void initialize() { super.initialize(); diff --git a/app/src/main/java/app/revanced/integrations/twitter/patches/links/OpenLinksWithAppChooserPatch.java b/app/src/main/java/app/revanced/integrations/twitter/patches/links/OpenLinksWithAppChooserPatch.java index 18ccaa78..c2907414 100644 --- a/app/src/main/java/app/revanced/integrations/twitter/patches/links/OpenLinksWithAppChooserPatch.java +++ b/app/src/main/java/app/revanced/integrations/twitter/patches/links/OpenLinksWithAppChooserPatch.java @@ -4,7 +4,9 @@ import android.content.Context; import android.content.Intent; import android.util.Log; +@SuppressWarnings("unused") public final class OpenLinksWithAppChooserPatch { + public static void openWithChooser(final Context context, final Intent intent) { Log.d("ReVanced", "Opening intent with chooser: " + intent); diff --git a/app/src/main/java/app/revanced/integrations/youtube/ThemeHelper.java b/app/src/main/java/app/revanced/integrations/youtube/ThemeHelper.java index c9f7536b..4a8fcea4 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/ThemeHelper.java +++ b/app/src/main/java/app/revanced/integrations/youtube/ThemeHelper.java @@ -38,6 +38,7 @@ public class ThemeHelper { /** * Injection point. + * @noinspection SameReturnValue */ private static String darkThemeResourceName() { // Value is changed by Theme patch, if included. @@ -57,6 +58,7 @@ public class ThemeHelper { /** * Injection point. + * @noinspection SameReturnValue */ private static String lightThemeResourceName() { // Value is changed by Theme patch, if included. diff --git a/app/src/main/java/app/revanced/integrations/youtube/TrieSearch.java b/app/src/main/java/app/revanced/integrations/youtube/TrieSearch.java index 1c927cd2..12b385a7 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/TrieSearch.java +++ b/app/src/main/java/app/revanced/integrations/youtube/TrieSearch.java @@ -380,7 +380,7 @@ public abstract class TrieSearch { throw new IllegalArgumentException("endIndex: " + endIndex + " is greater than texToSearchLength: " + textToSearchLength); } - if (patterns.size() == 0) { + if (patterns.isEmpty()) { return false; // No patterns were added. } for (int i = startIndex; i < endIndex; i++) { @@ -393,7 +393,7 @@ public abstract class TrieSearch { * @return Estimated memory size (in kilobytes) of this instance. */ public int getEstimatedMemorySize() { - if (patterns.size() == 0) { + if (patterns.isEmpty()) { return 0; } // Assume the device has less than 32GB of ram (and can use pointer compression), diff --git a/app/src/main/java/app/revanced/integrations/youtube/patches/BypassURLRedirectsPatch.java b/app/src/main/java/app/revanced/integrations/youtube/patches/BypassURLRedirectsPatch.java index c49f8bbd..bc5ce486 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/patches/BypassURLRedirectsPatch.java +++ b/app/src/main/java/app/revanced/integrations/youtube/patches/BypassURLRedirectsPatch.java @@ -18,7 +18,7 @@ public class BypassURLRedirectsPatch { public static Uri parseRedirectUri(String uri) { final var parsed = Uri.parse(uri); - if (Settings.BYPASS_URL_REDIRECTS.get() && parsed.getPath().equals(YOUTUBE_REDIRECT_PATH)) { + if (Settings.BYPASS_URL_REDIRECTS.get() && YOUTUBE_REDIRECT_PATH.equals(parsed.getPath())) { var query = Uri.parse(Uri.decode(parsed.getQueryParameter("q"))); Logger.printDebug(() -> "Bypassing YouTube redirect URI: " + query); diff --git a/app/src/main/java/app/revanced/integrations/youtube/patches/components/PlaybackSpeedMenuFilterPatch.java b/app/src/main/java/app/revanced/integrations/youtube/patches/components/PlaybackSpeedMenuFilterPatch.java index 03319588..73c38d29 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/patches/components/PlaybackSpeedMenuFilterPatch.java +++ b/app/src/main/java/app/revanced/integrations/youtube/patches/components/PlaybackSpeedMenuFilterPatch.java @@ -7,6 +7,7 @@ import app.revanced.integrations.youtube.patches.playback.speed.CustomPlaybackSp /** * Abuse LithoFilter for {@link CustomPlaybackSpeedPatch}. */ +@SuppressWarnings("unused") public final class PlaybackSpeedMenuFilterPatch extends Filter { // Must be volatile or synchronized, as litho filtering runs off main thread and this field is then access from the main thread. public static volatile boolean isPlaybackSpeedMenuVisible; diff --git a/app/src/main/java/app/revanced/integrations/youtube/patches/components/ReturnYouTubeDislikeFilterPatch.java b/app/src/main/java/app/revanced/integrations/youtube/patches/components/ReturnYouTubeDislikeFilterPatch.java index 927e4493..bb45e3c2 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/patches/components/ReturnYouTubeDislikeFilterPatch.java +++ b/app/src/main/java/app/revanced/integrations/youtube/patches/components/ReturnYouTubeDislikeFilterPatch.java @@ -26,6 +26,7 @@ import app.revanced.integrations.youtube.TrieSearch; * * Once a way to asynchronously update litho text is found, this strategy will no longer be needed. */ +@SuppressWarnings("unused") public final class ReturnYouTubeDislikeFilterPatch extends Filter { /** diff --git a/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/ReturnYouTubeDislike.java b/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/ReturnYouTubeDislike.java index bfff1b15..6632eb41 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/ReturnYouTubeDislike.java +++ b/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/ReturnYouTubeDislike.java @@ -69,7 +69,7 @@ public class ReturnYouTubeDislike { * Maximum amount of time to block the UI from updates while waiting for network call to complete. * * Must be less than 5 seconds, as per: - * https://developer.android.com/topic/performance/vitals/anr + * ... */ private static final long MAX_MILLISECONDS_TO_BLOCK_UI_WAITING_FOR_FETCH = 4000; diff --git a/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/requests/ReturnYouTubeDislikeApi.java b/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/requests/ReturnYouTubeDislikeApi.java index bc729e47..2d301e0b 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/requests/ReturnYouTubeDislikeApi.java +++ b/app/src/main/java/app/revanced/integrations/youtube/returnyoutubedislike/requests/ReturnYouTubeDislikeApi.java @@ -147,6 +147,7 @@ public class ReturnYouTubeDislikeApi { */ private static void randomlyWaitIfLocallyDebugging() { final boolean DEBUG_RANDOMLY_DELAY_NETWORK_CALLS = false; // set true to debug UI + //noinspection ConstantValue if (DEBUG_RANDOMLY_DELAY_NETWORK_CALLS) { final long amountOfTimeToWaste = (long) (Math.random() * (API_GET_VOTES_TCP_TIMEOUT_MILLISECONDS + API_GET_VOTES_HTTP_TIMEOUT_MILLISECONDS)); @@ -187,6 +188,7 @@ public class ReturnYouTubeDislikeApi { */ private static boolean checkIfRateLimitWasHit(int httpResponseCode) { final boolean DEBUG_RATE_LIMIT = false; // set to true, to verify rate limit works + //noinspection ConstantValue if (DEBUG_RATE_LIMIT) { final double RANDOM_RATE_LIMIT_PERCENTAGE = 0.2; // 20% chance of a triggering a rate limit if (Math.random() < RANDOM_RATE_LIMIT_PERCENTAGE) { @@ -569,7 +571,11 @@ public class ReturnYouTubeDislikeApi { throw new IllegalStateException("Failed to solve puzzle challenge: " + challenge + " difficulty: " + difficulty); } - // https://stackoverflow.com/a/157202 + /** + * ... + * + * @noinspection SameParameterValue + */ private static String randomString(int len) { String AB = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; SecureRandom rnd = new SecureRandom(); diff --git a/app/src/main/java/app/revanced/integrations/youtube/settings/preference/ReVancedPreferenceFragment.java b/app/src/main/java/app/revanced/integrations/youtube/settings/preference/ReVancedPreferenceFragment.java index 1f3bd6c0..2e4bc4c1 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/settings/preference/ReVancedPreferenceFragment.java +++ b/app/src/main/java/app/revanced/integrations/youtube/settings/preference/ReVancedPreferenceFragment.java @@ -3,13 +3,11 @@ package app.revanced.integrations.youtube.settings.preference; import android.os.Build; import android.preference.ListPreference; import android.preference.Preference; -import android.preference.PreferenceGroup; import androidx.annotation.RequiresApi; import app.revanced.integrations.shared.Logger; import app.revanced.integrations.shared.settings.preference.AbstractPreferenceFragment; -import app.revanced.integrations.youtube.patches.DownloadsPatch; import app.revanced.integrations.youtube.patches.playback.speed.CustomPlaybackSpeedPatch; import app.revanced.integrations.youtube.settings.Settings; @@ -21,6 +19,7 @@ import app.revanced.integrations.youtube.settings.Settings; public class ReVancedPreferenceFragment extends AbstractPreferenceFragment { @RequiresApi(api = Build.VERSION_CODES.O) + @SuppressWarnings("unused") @Override protected void initialize() { super.initialize(); diff --git a/app/src/main/java/app/revanced/integrations/youtube/shared/PlayerType.kt b/app/src/main/java/app/revanced/integrations/youtube/shared/PlayerType.kt index 9a5275b6..6461c18a 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/shared/PlayerType.kt +++ b/app/src/main/java/app/revanced/integrations/youtube/shared/PlayerType.kt @@ -46,7 +46,7 @@ enum class PlayerType { companion object { - private val nameToPlayerType = values().associateBy { it.name } + private val nameToPlayerType = entries.associateBy { it.name } @JvmStatic fun setFromString(enumName: String) { diff --git a/app/src/main/java/app/revanced/integrations/youtube/shared/VideoState.kt b/app/src/main/java/app/revanced/integrations/youtube/shared/VideoState.kt index 75db347b..893360b1 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/shared/VideoState.kt +++ b/app/src/main/java/app/revanced/integrations/youtube/shared/VideoState.kt @@ -22,7 +22,7 @@ enum class VideoState { companion object { - private val nameToVideoState = values().associateBy { it.name } + private val nameToVideoState = entries.associateBy { it.name } @JvmStatic fun setFromString(enumName: String) { diff --git a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/SegmentPlaybackController.java b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/SegmentPlaybackController.java index 9a35adce..d8576f71 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/SegmentPlaybackController.java +++ b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/SegmentPlaybackController.java @@ -182,6 +182,7 @@ public class SegmentPlaybackController { * Injection point. * Initializes SponsorBlock when the video player starts playing a new video. */ + @SuppressWarnings("unused") public static void initialize(Object ignoredPlayerController) { try { Utils.verifyOnMainThread(); diff --git a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/requests/SBRequester.java b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/requests/SBRequester.java index 9e25e9f6..c2487dbf 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/requests/SBRequester.java +++ b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/requests/SBRequester.java @@ -113,6 +113,7 @@ public class SBRequester { // Could benefit from: // 1) collection of YouTube videos with test segment times (verify client skip timing matches the video, verify seekbar draws correctly) // 2) unit tests (verify everything else) + //noinspection ConstantValue if (false) { segments.clear(); // Test auto-hide skip button: diff --git a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/CreateSegmentButtonController.java b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/CreateSegmentButtonController.java index dffdf9ff..ff0dec8f 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/CreateSegmentButtonController.java +++ b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/CreateSegmentButtonController.java @@ -14,6 +14,7 @@ import app.revanced.integrations.shared.Logger; import app.revanced.integrations.shared.Utils; import app.revanced.integrations.youtube.videoplayer.BottomControlButton; +/** @noinspection unused*/ public class CreateSegmentButtonController { private static WeakReference buttonReference = new WeakReference<>(null); private static boolean isShowing; diff --git a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/SkipSponsorButton.java b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/SkipSponsorButton.java index f3b954d4..d98282a4 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/SkipSponsorButton.java +++ b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/SkipSponsorButton.java @@ -92,6 +92,7 @@ public class SkipSponsorButton extends FrameLayout { public boolean updateSkipButtonText(@NonNull SponsorSegment segment) { this.segment = segment; CharSequence newText = segment.getSkipButtonText(); + //noinspection StringEqualsCharSequence if (newText.equals(skipSponsorTextView.getText())) { return false; } diff --git a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/VotingButtonController.java b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/VotingButtonController.java index 581ba1ad..2f753475 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/VotingButtonController.java +++ b/app/src/main/java/app/revanced/integrations/youtube/sponsorblock/ui/VotingButtonController.java @@ -29,9 +29,7 @@ public class VotingButtonController { ImageView imageView = Objects.requireNonNull(youtubeControlsLayout.findViewById( getResourceIdentifier("revanced_sb_voting_button", "id"))); imageView.setVisibility(View.GONE); - imageView.setOnClickListener(v -> { - SponsorBlockUtils.onVotingClicked(v.getContext()); - }); + imageView.setOnClickListener(v -> SponsorBlockUtils.onVotingClicked(v.getContext())); buttonReference = new WeakReference<>(imageView); } catch (Exception ex) { diff --git a/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlButton.java b/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlButton.java index 5995da96..fa240dcf 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlButton.java +++ b/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlButton.java @@ -9,6 +9,7 @@ import app.revanced.integrations.youtube.patches.CopyVideoUrlPatch; import app.revanced.integrations.youtube.settings.Settings; import app.revanced.integrations.shared.Logger; +/** @noinspection unused*/ public class CopyVideoUrlButton extends BottomControlButton { @Nullable private static CopyVideoUrlButton instance; diff --git a/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlTimestampButton.java b/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlTimestampButton.java index 41af50ac..abf927b5 100644 --- a/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlTimestampButton.java +++ b/app/src/main/java/app/revanced/integrations/youtube/videoplayer/CopyVideoUrlTimestampButton.java @@ -9,6 +9,7 @@ import app.revanced.integrations.youtube.patches.CopyVideoUrlPatch; import app.revanced.integrations.youtube.settings.Settings; import app.revanced.integrations.shared.Logger; +/** @noinspection unused*/ public class CopyVideoUrlTimestampButton extends BottomControlButton { @Nullable private static CopyVideoUrlTimestampButton instance;