From 307315c43c68a47c983384351a617f5c5f508b4f Mon Sep 17 00:00:00 2001 From: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com> Date: Mon, 22 May 2023 05:51:19 +0400 Subject: [PATCH] fix(youtube/return-youtube-dislike): fix dislikes not showing for video opened from feed autoplay (#408) --- .../returnyoutubedislike/ReturnYouTubeDislike.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/app/revanced/integrations/returnyoutubedislike/ReturnYouTubeDislike.java b/app/src/main/java/app/revanced/integrations/returnyoutubedislike/ReturnYouTubeDislike.java index 741b9a64..fc577f53 100644 --- a/app/src/main/java/app/revanced/integrations/returnyoutubedislike/ReturnYouTubeDislike.java +++ b/app/src/main/java/app/revanced/integrations/returnyoutubedislike/ReturnYouTubeDislike.java @@ -239,12 +239,6 @@ public class ReturnYouTubeDislike { public static void newVideoLoaded(@NonNull String videoId) { Objects.requireNonNull(videoId); - PlayerType currentPlayerType = PlayerType.getCurrent(); - if (currentPlayerType == PlayerType.INLINE_MINIMAL) { - LogHelper.printDebug(() -> "Ignoring inline playback of video: " + videoId); - setCurrentVideoId(null); - return; - } synchronized (videoIdLockObject) { if (videoId.equals(currentVideoId)) { return; // already loaded @@ -254,13 +248,14 @@ public class ReturnYouTubeDislike { setCurrentVideoId(null); return; } + PlayerType currentPlayerType = PlayerType.getCurrent(); LogHelper.printDebug(() -> "New video loaded: " + videoId + " playerType: " + currentPlayerType); setCurrentVideoId(videoId); // If a Short is opened while a regular video is on screen, this will incorrectly set this as false. // But this check is needed to fix unusual situations of opening/closing the app // while both a regular video and a short are on screen. - dislikeDataIsShort = PlayerType.getCurrent().isNoneHiddenOrMinimized(); + dislikeDataIsShort = currentPlayerType.isNoneHiddenOrMinimized(); RYDCachedFetch entry = futureCache.get(videoId); if (entry != null && entry.futureInProgressOrFinishedSuccessfully()) {