fix: revert semantically incorrect simplification of ˋAdRemoverAPI.HideViewWithLayout1dpˋ (#244)

This commit is contained in:
oSumAtrIX 2022-12-21 14:37:05 +01:00 committed by GitHub
parent 5839f6ca4a
commit 71e81a6473
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -3,6 +3,11 @@ package app.revanced.integrations.adremover;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.FrameLayout;
import android.widget.LinearLayout;
import android.widget.RelativeLayout;
import android.widget.Toolbar;
import app.revanced.integrations.utils.LogHelper; import app.revanced.integrations.utils.LogHelper;
public class AdRemoverAPI { public class AdRemoverAPI {
@ -14,12 +19,24 @@ public class AdRemoverAPI {
*/ */
//ToDo: refactor this //ToDo: refactor this
public static void HideViewWithLayout1dp(View view) { public static void HideViewWithLayout1dp(View view) {
if (view instanceof ViewGroup) { if (view instanceof LinearLayout) {
ViewGroup.LayoutParams layoutParams = new ViewGroup.LayoutParams(1, 1); LinearLayout.LayoutParams layoutParams = new LinearLayout.LayoutParams(1, 1);
view.setLayoutParams(layoutParams); view.setLayoutParams(layoutParams);
return; } else if (view instanceof FrameLayout) {
FrameLayout.LayoutParams layoutParams2 = new FrameLayout.LayoutParams(1, 1);
view.setLayoutParams(layoutParams2);
} else if (view instanceof RelativeLayout) {
RelativeLayout.LayoutParams layoutParams3 = new RelativeLayout.LayoutParams(1, 1);
view.setLayoutParams(layoutParams3);
} else if (view instanceof Toolbar) {
Toolbar.LayoutParams layoutParams4 = new Toolbar.LayoutParams(1, 1);
view.setLayoutParams(layoutParams4);
} else if (view instanceof ViewGroup) {
ViewGroup.LayoutParams layoutParams5 = new ViewGroup.LayoutParams(1, 1);
view.setLayoutParams(layoutParams5);
} else {
LogHelper.printDebug(() -> "HideViewWithLayout1dp - Id: " + view.getId() + " Type: " + view.getClass().getName());
} }
LogHelper.printDebug(
() -> "HideViewWithLayout1dp - Id: " + view.getId() + " Type: " + view.getClass().getName());
} }
} }