ReVanced-Mirror/revanced-integrations
1
0
Fork 0
mirror of https://github.com/revanced/revanced-integrations.git synced 2025-01-21 01:07:32 +01:00
Code Issues Projects Releases Wiki Activity

fix: ensure thread safety for class StringRef (#273)

Browse Source
This commit is contained in:
LisoUseInAIKyrios 2023-01-06 01:21:41 +04:00 committed by GitHub
parent 954e60191e
commit f5c5fcb5e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/app/revanced/integrations/sponsorblock/StringRef.java
View File

@ -5,16 +5,20 @@ import android.content.res.Resources;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map;
import app.revanced.integrations.utils.LogHelper; import app.revanced.integrations.utils.LogHelper;
import app.revanced.integrations.utils.ReVancedUtils; import app.revanced.integrations.utils.ReVancedUtils;
// should probably move this class into utils package
public class StringRef { public class StringRef {
private static Resources resources; private static Resources resources;
private static String packageName; private static String packageName;
private static final HashMap<String, StringRef> strings = new HashMap<>(); // must use a thread safe map, as this class is used both on and off the main thread
private static final Map<String, StringRef> strings = Collections.synchronizedMap(new HashMap());
/** /**
* Gets strings reference from shared collection or creates if not exists yet, * Gets strings reference from shared collection or creates if not exists yet,
@ -90,9 +94,11 @@ public class StringRef {
@NonNull @NonNull
public String toString() { public String toString() {
if (!resolved) { if (!resolved) {
Context context = ReVancedUtils.getContext(); if (resources == null || packageName == null) {
resources = context.getResources(); Context context = ReVancedUtils.getContext();
packageName = context.getPackageName(); resources = context.getResources();
packageName = context.getPackageName();
}
resolved = true; resolved = true;
if (resources != null) { if (resources != null) {
final int identifier = resources.getIdentifier(value, "string", packageName); final int identifier = resources.getIdentifier(value, "string", packageName);