ReVanced-Mirror/revanced-manager-compose
1
0
Fork 0
mirror of https://github.com/revanced/revanced-manager-compose synced 2024-10-13 00:48:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(settings screen): clean code up a bit

Browse Source
This commit is contained in:
Aunali321 2023-05-22 02:29:19 +05:30
parent a2bf4b165e
commit b38f0d96e0
1 changed files with 43 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
app/src/main/java/app/revanced/manager/compose/ui/screen/SettingsScreen.kt
View File

@ -12,6 +12,7 @@ import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.outlined.* import androidx.compose.material.icons.outlined.*
import androidx.compose.material3.* import androidx.compose.material3.*
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.Stable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@ -25,14 +26,43 @@ import org.koin.androidx.compose.getViewModel
@OptIn(ExperimentalMaterial3Api::class, ExperimentalAnimationApi::class) @OptIn(ExperimentalMaterial3Api::class, ExperimentalAnimationApi::class)
@Composable @Composable
@Stable
fun SettingsScreen( fun SettingsScreen(
onBackClick: () -> Unit, onBackClick: () -> Unit,
viewModel: SettingsViewModel = getViewModel() viewModel: SettingsViewModel = getViewModel()
) { ) {
val navController = rememberNavController<SettingsDestination>(startDestination = SettingsDestination.Settings) val navController =
rememberNavController<SettingsDestination>(startDestination = SettingsDestination.Settings)
val settingsSections = listOf(
Triple(
R.string.general,
R.string.general_description,
Icons.Outlined.Settings
) to SettingsDestination.General,
Triple(
R.string.updates,
R.string.updates_description,
Icons.Outlined.Update
) to SettingsDestination.Updates,
Triple(
R.string.downloads,
R.string.downloads_description,
Icons.Outlined.Download
) to SettingsDestination.Downloads,
Triple(
R.string.import_export,
R.string.import_export_description,
Icons.Outlined.SwapVert
) to SettingsDestination.ImportExport,
Triple(
R.string.about,
R.string.about_description,
Icons.Outlined.Info
) to SettingsDestination.About,
)
NavBackHandler(navController) NavBackHandler(navController)
AnimatedNavHost( AnimatedNavHost(
controller = navController controller = navController
) { destination -> ) { destination ->
@ -60,14 +90,13 @@ fun SettingsScreen(
) )
is SettingsDestination.Settings -> { is SettingsDestination.Settings -> {
Scaffold( Scaffold(
topBar = { topBar = {
AppTopBar( AppTopBar(
title = stringResource(R.string.settings), title = stringResource(R.string.settings),
onBackClick = onBackClick, onBackClick = onBackClick,
actions = {
}
) )
} }
) { paddingValues -> ) { paddingValues ->
@ -78,45 +107,17 @@ fun SettingsScreen(
.verticalScroll(rememberScrollState()), .verticalScroll(rememberScrollState()),
verticalArrangement = Arrangement.spacedBy(12.dp) verticalArrangement = Arrangement.spacedBy(12.dp)
) { ) {
settingsSections.forEach { (titleDescIcon, destination) ->
ListItem( ListItem(
modifier = Modifier.clickable { navController.navigate(SettingsDestination.General) }, modifier = Modifier.clickable { navController.navigate(destination) },
leadingContent = { Icon(Icons.Outlined.Settings, null) }, headlineContent = { Text(stringResource(titleDescIcon.first)) },
headlineContent = { Text(stringResource(R.string.general)) }, supportingContent = { Text(stringResource(titleDescIcon.second)) },
supportingContent = { Text(stringResource(R.string.general_description)) } leadingContent = { Icon(titleDescIcon.third, null) }
) )
}
ListItem(
modifier = Modifier.clickable { navController.navigate(SettingsDestination.Updates) },
leadingContent = { Icon(Icons.Outlined.Update, null) },
headlineContent = { Text(stringResource(R.string.updates)) },
supportingContent = { Text(stringResource(R.string.updates_description)) }
)
ListItem(
modifier = Modifier.clickable { navController.navigate(SettingsDestination.Downloads) },
leadingContent = { Icon(Icons.Outlined.Download, null) },
headlineContent = { Text(stringResource(R.string.downloads)) },
supportingContent = { Text(stringResource(R.string.downloads_description)) }
)
ListItem(
modifier = Modifier.clickable { navController.navigate(SettingsDestination.ImportExport) },
leadingContent = { Icon(Icons.Outlined.ImportExport, null) },
headlineContent = { Text(stringResource(R.string.import_export)) },
supportingContent = { Text(stringResource(R.string.import_export_description)) }
)
ListItem(
modifier = Modifier.clickable { navController.navigate(SettingsDestination.About) },
leadingContent = { Icon(Icons.Outlined.Info, null) },
headlineContent = { Text(stringResource(R.string.about)) },
supportingContent = { Text(stringResource(R.string.about_description)) }
)
} }
} }
} }
} }
} }
} }