From 20a29bc924f732e8ba3039821edbe8ab7b1dbe8c Mon Sep 17 00:00:00 2001
From: Taylor Kline <tkline@thebhwgroup.com>
Date: Tue, 16 Apr 2024 14:53:28 -0500
Subject: [PATCH] fix: default to non-multithreaded until ui toggle support

Patching large applications (e.g. TikTok) on Android with multithreading simply doesn't work on multicore devices where the amount of memory given to the manager (regardless of the system RAM) is not sufficient.

It's more important that patching succeeds for all available use cases than for only some patching to succeed with faster performance. A UI option can be added later, but the multithreading option should be opt-out by default rather than opt-in.

Closes ReVanced/revanced-documentation#35
Closes ReVanced/revanced-manager#1454
Closes ReVanced/revanced-manager#1571
Closes ReVanced/revanced-manager#1595
Closes ReVanced/revanced-manager#1659
Closes ReVanced/revanced-manager#1661
Closes ReVanced/revanced-manager#1684
Closes ReVanced/revanced-manager#1759
Closes ReVanced/revanced-manager#1802
Closes ReVanced/revanced-manager#1817
Closes ReVanced/revanced-patches#2885
Closes ReVanced/revanced-manager#592
Closes ReVanced/revanced-patcher#193
Closes ReVanced/revanced-patches#1533
Closes ReVanced/revanced-patches#1608
Closes ReVanced/revanced-patches#1613
Closes ReVanced/revanced-patches#1630
Closes ReVanced/revanced-patches#190
Closes ReVanced/revanced-patches#2511
Closes ReVanced/revanced-patches#525
---
 .../main/kotlin/app/revanced/manager/flutter/MainActivity.kt    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt b/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt
index f0fc99b6..08871beb 100644
--- a/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt
+++ b/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt
@@ -279,7 +279,7 @@ class MainActivity : FlutterActivity() {
                         tmpDir,
                         Aapt.binary(applicationContext).absolutePath,
                         tmpDir.path,
-                        true // TODO: Add option to disable this
+                        false // TODO: Add option to toggle multithreading in UI
                     )
                 )