From 6f4866ef639882f2c3648c7f3b15128f011da8da Mon Sep 17 00:00:00 2001 From: Benjamin Halko Date: Wed, 20 Sep 2023 20:03:15 -0700 Subject: [PATCH 1/2] fix: default theme not following system (#1288) --- lib/ui/theme/dynamic_theme_builder.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ui/theme/dynamic_theme_builder.dart b/lib/ui/theme/dynamic_theme_builder.dart index 5fcd8831..233c78b5 100644 --- a/lib/ui/theme/dynamic_theme_builder.dart +++ b/lib/ui/theme/dynamic_theme_builder.dart @@ -90,7 +90,7 @@ class _DynamicThemeBuilderState extends State with WidgetsB 4: darkCustomTheme, 5: darkDynamicTheme, }, - fallbackTheme: brightness == Brightness.light ? lightCustomTheme : darkCustomTheme, + fallbackTheme: PlatformDispatcher.instance.platformBrightness == Brightness.light ? lightCustomTheme : darkCustomTheme, ), builder: (context, theme) => MaterialApp( debugShowCheckedModeBanner: false, From e01b323aee992fa274722df78dfe0baa8d38e923 Mon Sep 17 00:00:00 2001 From: Benjamin Halko Date: Wed, 20 Sep 2023 20:03:47 -0700 Subject: [PATCH 2/2] fix: make entire theme item clickable --- .../views/settings/settingsFragment/settings_update_theme.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ui/views/settings/settingsFragment/settings_update_theme.dart b/lib/ui/views/settings/settingsFragment/settings_update_theme.dart index 1abd0f8c..1d15a168 100644 --- a/lib/ui/views/settings/settingsFragment/settings_update_theme.dart +++ b/lib/ui/views/settings/settingsFragment/settings_update_theme.dart @@ -157,6 +157,7 @@ class SUpdateThemeUI extends StatelessWidget { label: sUpdateTheme.getThemeModeName(), onPressed: () => { sUpdateTheme.showThemeDialog(context) }, ), + onTap: () => { sUpdateTheme.showThemeDialog(context) }, ), FutureBuilder( future: _settingViewModel.getSdkVersion(),