From 28d24fa33c10da9fa812b777ddffbcf9b3a3f682 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Sun, 26 Feb 2023 23:10:35 +0100 Subject: [PATCH] refactor(youtube/hide-timestamp): use better descriptions Signed-off-by: oSumAtrIX --- .../app/revanced/integrations/patches/HideTimePatch.java | 9 --------- .../integrations/patches/HideTimestampPatch.java | 9 +++++++++ .../app/revanced/integrations/settings/SettingsEnum.java | 8 ++++++-- 3 files changed, 15 insertions(+), 11 deletions(-) delete mode 100644 integrations/java/app/revanced/integrations/patches/HideTimePatch.java create mode 100644 integrations/java/app/revanced/integrations/patches/HideTimestampPatch.java diff --git a/integrations/java/app/revanced/integrations/patches/HideTimePatch.java b/integrations/java/app/revanced/integrations/patches/HideTimePatch.java deleted file mode 100644 index 87f023d3f..000000000 --- a/integrations/java/app/revanced/integrations/patches/HideTimePatch.java +++ /dev/null @@ -1,9 +0,0 @@ -package app.revanced.integrations.patches; - -import app.revanced.integrations.settings.SettingsEnum; - -public class HideTimePatch { - public static boolean hideTime() { - return SettingsEnum.HIDE_TIME.getBoolean(); - } -} diff --git a/integrations/java/app/revanced/integrations/patches/HideTimestampPatch.java b/integrations/java/app/revanced/integrations/patches/HideTimestampPatch.java new file mode 100644 index 000000000..9bb85294a --- /dev/null +++ b/integrations/java/app/revanced/integrations/patches/HideTimestampPatch.java @@ -0,0 +1,9 @@ +package app.revanced.integrations.patches; + +import app.revanced.integrations.settings.SettingsEnum; + +public class HideTimestampPatch { + public static boolean hideTimestamp() { + return SettingsEnum.HIDE_TIMESTAMP.getBoolean(); + } +} diff --git a/integrations/java/app/revanced/integrations/settings/SettingsEnum.java b/integrations/java/app/revanced/integrations/settings/SettingsEnum.java index e47d7d497..7dacf3185 100644 --- a/integrations/java/app/revanced/integrations/settings/SettingsEnum.java +++ b/integrations/java/app/revanced/integrations/settings/SettingsEnum.java @@ -91,7 +91,7 @@ public enum SettingsEnum { HIDE_REEL_BUTTON("revanced_hide_reel_button", true, ReturnType.BOOLEAN, true), HIDE_SHORTS_BUTTON("revanced_hide_shorts_button", true, ReturnType.BOOLEAN, true), HIDE_SHORTS_COMMENTS_BUTTON("revanced_hide_shorts_comments_button", false, ReturnType.BOOLEAN), - HIDE_TIME("revanced_hide_time", false, ReturnType.BOOLEAN), + HIDE_TIMESTAMP("revanced_hide_timestamp", false, ReturnType.BOOLEAN), HIDE_SEEKBAR("revanced_hide_seekbar", false, ReturnType.BOOLEAN), HIDE_WATCH_IN_VR("revanced_hide_watch_in_vr", false, ReturnType.BOOLEAN, true), HIDE_BREAKING_NEWS("revanced_hide_breaking_news", true, ReturnType.BOOLEAN, true), @@ -194,7 +194,10 @@ public enum SettingsEnum { @Deprecated DEPRECATED_COPY_VIDEO_URL_BUTTON_SHOWN("revanced_copy_video_url", true, ReturnType.BOOLEAN, true), @Deprecated - DEPRECATED_COPY_VIDEO_URL_TIMESTAMP_BUTTON_SHOWN("revanced_copy_video_url_timestamp", true, ReturnType.BOOLEAN, true); + DEPRECATED_COPY_VIDEO_URL_TIMESTAMP_BUTTON_SHOWN("revanced_copy_video_url_timestamp", true, ReturnType.BOOLEAN, true), + @Deprecated + DEPRECATED_HIDE_TIME("revanced_hide_time", false, ReturnType.BOOLEAN); + // // end deprecated settings // @@ -247,6 +250,7 @@ public enum SettingsEnum { {DEPRECATED_CAST_BUTTON_SHOWN, HIDE_CAST_BUTTON}, {DEPRECATED_BRANDING_SHOWN, HIDE_VIDEO_WATERMARK}, {DEPRECATED_REMEMBER_VIDEO_QUALITY, REMEMBER_VIDEO_QUALITY_LAST_SELECTED}, + {DEPRECATED_HIDE_TIME, HIDE_TIMESTAMP} }; for (SettingsEnum[] oldNewSetting : invertedSettingsToMigrate) { // by default, old setting was default off