2020-08-13 21:08:54 +02:00
|
|
|
/*
|
|
|
|
SPDX-FileCopyrightText: 2014 Marco Martin <mart@kde.org>
|
|
|
|
|
|
|
|
SPDX-License-Identifier: LGPL-2.0-or-later
|
|
|
|
*/
|
2014-07-21 19:38:11 +02:00
|
|
|
|
|
|
|
#include "framesvgtest.h"
|
|
|
|
#include <QStandardPaths>
|
|
|
|
|
|
|
|
void FrameSvgTest::initTestCase()
|
|
|
|
{
|
2019-02-28 13:55:40 +01:00
|
|
|
QStandardPaths::setTestModeEnabled(true);
|
2014-09-30 18:12:26 +02:00
|
|
|
m_cacheDir = QDir(QStandardPaths::writableLocation(QStandardPaths::CacheLocation));
|
|
|
|
m_cacheDir.removeRecursively();
|
|
|
|
|
2014-07-21 19:38:11 +02:00
|
|
|
m_frameSvg = new Plasma::FrameSvg;
|
|
|
|
m_frameSvg->setImagePath(QFINDTESTDATA("data/background.svgz"));
|
|
|
|
QVERIFY(m_frameSvg->isValid());
|
|
|
|
}
|
|
|
|
|
|
|
|
void FrameSvgTest::cleanupTestCase()
|
|
|
|
{
|
|
|
|
delete m_frameSvg;
|
2014-09-30 18:12:26 +02:00
|
|
|
|
|
|
|
m_cacheDir.removeRecursively();
|
2014-07-21 19:38:11 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void FrameSvgTest::margins()
|
|
|
|
{
|
|
|
|
QCOMPARE(m_frameSvg->marginSize(Plasma::Types::LeftMargin), (qreal)26);
|
|
|
|
QCOMPARE(m_frameSvg->marginSize(Plasma::Types::TopMargin), (qreal)26);
|
|
|
|
QCOMPARE(m_frameSvg->marginSize(Plasma::Types::RightMargin), (qreal)26);
|
|
|
|
QCOMPARE(m_frameSvg->marginSize(Plasma::Types::BottomMargin), (qreal)26);
|
|
|
|
}
|
|
|
|
|
|
|
|
void FrameSvgTest::contentsRect()
|
|
|
|
{
|
2021-03-05 19:15:32 +01:00
|
|
|
m_frameSvg->resizeFrame(QSize(100, 100));
|
2014-07-21 19:38:11 +02:00
|
|
|
QCOMPARE(m_frameSvg->contentsRect(), QRectF(26, 26, 48, 48));
|
|
|
|
}
|
|
|
|
|
don't regenerate frames when setting every property
Summary:
give frameSvg the concept of repaintBlocked(), that enables and
disables the regeneration of the frame data when a property is set.
the use case is when often, a lot of properties are set one after
the other (such as prefix, enabled borders, size)
collapse the formely similar, but a bit different logic of frame
regeneration is a single function for better maintanability.
QML FrameSvgItem sets repaintblocked when it starts and releases it just on oncomponentCompleted
Test Plan:
plasmashell still starts, autotests still work, all frames are rendered correctly
the destruction of old frames is cutted by 50%. in the qml profiler
the creation time of a framesvgitem slightly improved, on this machine from around 26 msecs to around 21, can still be improved, but at least the code is a bit simpler
Reviewers: #plasma
Subscribers: davidedmundson, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D4414
2017-02-07 13:05:57 +01:00
|
|
|
void FrameSvgTest::repaintBlocked()
|
|
|
|
{
|
2021-03-05 19:15:32 +01:00
|
|
|
// check the properties to be correct even if set during a repaint blocked transaction
|
don't regenerate frames when setting every property
Summary:
give frameSvg the concept of repaintBlocked(), that enables and
disables the regeneration of the frame data when a property is set.
the use case is when often, a lot of properties are set one after
the other (such as prefix, enabled borders, size)
collapse the formely similar, but a bit different logic of frame
regeneration is a single function for better maintanability.
QML FrameSvgItem sets repaintblocked when it starts and releases it just on oncomponentCompleted
Test Plan:
plasmashell still starts, autotests still work, all frames are rendered correctly
the destruction of old frames is cutted by 50%. in the qml profiler
the creation time of a framesvgitem slightly improved, on this machine from around 26 msecs to around 21, can still be improved, but at least the code is a bit simpler
Reviewers: #plasma
Subscribers: davidedmundson, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D4414
2017-02-07 13:05:57 +01:00
|
|
|
m_frameSvg->setRepaintBlocked(true);
|
|
|
|
QVERIFY(m_frameSvg->isRepaintBlocked());
|
|
|
|
|
|
|
|
m_frameSvg->setElementPrefix("prefix");
|
2021-03-05 19:15:32 +01:00
|
|
|
m_frameSvg->setEnabledBorders(Plasma::FrameSvg::TopBorder | Plasma::FrameSvg::LeftBorder);
|
|
|
|
m_frameSvg->resizeFrame(QSizeF(100, 100));
|
|
|
|
|
don't regenerate frames when setting every property
Summary:
give frameSvg the concept of repaintBlocked(), that enables and
disables the regeneration of the frame data when a property is set.
the use case is when often, a lot of properties are set one after
the other (such as prefix, enabled borders, size)
collapse the formely similar, but a bit different logic of frame
regeneration is a single function for better maintanability.
QML FrameSvgItem sets repaintblocked when it starts and releases it just on oncomponentCompleted
Test Plan:
plasmashell still starts, autotests still work, all frames are rendered correctly
the destruction of old frames is cutted by 50%. in the qml profiler
the creation time of a framesvgitem slightly improved, on this machine from around 26 msecs to around 21, can still be improved, but at least the code is a bit simpler
Reviewers: #plasma
Subscribers: davidedmundson, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D4414
2017-02-07 13:05:57 +01:00
|
|
|
m_frameSvg->setRepaintBlocked(false);
|
|
|
|
|
|
|
|
QCOMPARE(m_frameSvg->prefix(), QString("prefix"));
|
2021-03-05 19:15:32 +01:00
|
|
|
QCOMPARE(m_frameSvg->enabledBorders(), Plasma::FrameSvg::TopBorder | Plasma::FrameSvg::LeftBorder);
|
|
|
|
QCOMPARE(m_frameSvg->frameSize(), QSizeF(100, 100));
|
don't regenerate frames when setting every property
Summary:
give frameSvg the concept of repaintBlocked(), that enables and
disables the regeneration of the frame data when a property is set.
the use case is when often, a lot of properties are set one after
the other (such as prefix, enabled borders, size)
collapse the formely similar, but a bit different logic of frame
regeneration is a single function for better maintanability.
QML FrameSvgItem sets repaintblocked when it starts and releases it just on oncomponentCompleted
Test Plan:
plasmashell still starts, autotests still work, all frames are rendered correctly
the destruction of old frames is cutted by 50%. in the qml profiler
the creation time of a framesvgitem slightly improved, on this machine from around 26 msecs to around 21, can still be improved, but at least the code is a bit simpler
Reviewers: #plasma
Subscribers: davidedmundson, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D4414
2017-02-07 13:05:57 +01:00
|
|
|
}
|
|
|
|
|
2016-03-12 13:02:34 +01:00
|
|
|
void FrameSvgTest::setTheme()
|
|
|
|
{
|
|
|
|
// Should not crash
|
|
|
|
|
|
|
|
Plasma::FrameSvg *frameSvg = new Plasma::FrameSvg;
|
|
|
|
frameSvg->setImagePath("widgets/background");
|
|
|
|
frameSvg->setTheme(new Plasma::Theme("breeze-light", this));
|
|
|
|
frameSvg->framePixmap();
|
|
|
|
frameSvg->setTheme(new Plasma::Theme("breeze-dark", this));
|
|
|
|
frameSvg->framePixmap();
|
|
|
|
delete frameSvg;
|
|
|
|
|
|
|
|
frameSvg = new Plasma::FrameSvg;
|
|
|
|
frameSvg->setImagePath("widgets/background");
|
|
|
|
frameSvg->setTheme(new Plasma::Theme("breeze-light", this));
|
|
|
|
frameSvg->framePixmap();
|
|
|
|
frameSvg->setTheme(new Plasma::Theme("breeze-dark", this));
|
|
|
|
frameSvg->framePixmap();
|
|
|
|
delete frameSvg;
|
|
|
|
}
|
|
|
|
|
2014-07-21 19:38:11 +02:00
|
|
|
QTEST_MAIN(FrameSvgTest)
|