2020-08-13 21:08:54 +02:00
|
|
|
/*
|
|
|
|
SPDX-FileCopyrightText: 2014 Marco Martin <mart@kde.org>
|
|
|
|
|
|
|
|
SPDX-License-Identifier: LGPL-2.0-or-later
|
|
|
|
*/
|
2014-07-21 19:38:11 +02:00
|
|
|
#ifndef FRAMESVGTEST_H
|
|
|
|
#define FRAMESVGTEST_H
|
|
|
|
|
2019-12-14 16:58:05 +01:00
|
|
|
#include <QTest>
|
2014-07-21 19:38:11 +02:00
|
|
|
|
|
|
|
|
|
|
|
#include "plasma/framesvg.h"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class FrameSvgTest : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
|
|
|
|
public Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void cleanupTestCase();
|
|
|
|
|
|
|
|
private Q_SLOTS:
|
|
|
|
void margins();
|
|
|
|
void contentsRect();
|
2016-03-12 13:02:34 +01:00
|
|
|
void setTheme();
|
don't regenerate frames when setting every property
Summary:
give frameSvg the concept of repaintBlocked(), that enables and
disables the regeneration of the frame data when a property is set.
the use case is when often, a lot of properties are set one after
the other (such as prefix, enabled borders, size)
collapse the formely similar, but a bit different logic of frame
regeneration is a single function for better maintanability.
QML FrameSvgItem sets repaintblocked when it starts and releases it just on oncomponentCompleted
Test Plan:
plasmashell still starts, autotests still work, all frames are rendered correctly
the destruction of old frames is cutted by 50%. in the qml profiler
the creation time of a framesvgitem slightly improved, on this machine from around 26 msecs to around 21, can still be improved, but at least the code is a bit simpler
Reviewers: #plasma
Subscribers: davidedmundson, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D4414
2017-02-07 13:05:57 +01:00
|
|
|
void repaintBlocked();
|
2014-07-21 19:38:11 +02:00
|
|
|
|
|
|
|
private:
|
|
|
|
Plasma::FrameSvg *m_frameSvg;
|
2014-09-30 18:12:26 +02:00
|
|
|
QDir m_cacheDir;
|
2014-07-21 19:38:11 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|