From 02ec1b77c23e0402e540af8c3821ca44d9500ca4 Mon Sep 17 00:00:00 2001 From: Fabian Vogt Date: Wed, 27 Feb 2019 18:51:07 +0100 Subject: [PATCH] Show a warning if a plugin requires a newer version Summary: Currently it just fails silently. Test Plan: Loaded a plasmoid with an incompatible plugin, warning is shown. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: kde-frameworks-devel, plasma-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19394 --- src/plasma/pluginloader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plasma/pluginloader.cpp b/src/plasma/pluginloader.cpp index 461a6540f..298c89a53 100644 --- a/src/plasma/pluginloader.cpp +++ b/src/plasma/pluginloader.cpp @@ -904,11 +904,9 @@ bool PluginLoader::isPluginVersionCompatible(KPluginLoader &loader) const quint32 maxVersion = PLASMA_MAKE_VERSION(PLASMA_VERSION_MAJOR, PLASMA_VERSION_MINOR, 60); if (version < minVersion || version > maxVersion) { -#ifndef NDEBUG - qCDebug(LOG_PLASMA) << loader.fileName() << ": this plugin is compiled against incompatible Plasma version" << version + qCWarning(LOG_PLASMA) << loader.fileName() << ": this plugin is compiled against incompatible Plasma version" << version << "This build is compatible with" << PLASMA_VERSION_MAJOR << ".0.0 (" << minVersion << ") to" << PLASMA_VERSION_STRING << "(" << maxVersion << ")"; -#endif return false; }