Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

Summary:
During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3

As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".

Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.

Reviewers: #plasma, #vdg

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20602
This commit is contained in:
Friedrich W. H. Kossebau 2019-04-16 14:57:26 +02:00
parent cdad9c38c1
commit 084edba0db
2 changed files with 14 additions and 0 deletions

View File

@ -578,6 +578,13 @@
width="3.4471455" width="3.4471455"
id="hint-bar-stretch" id="hint-bar-stretch"
style="fill:#3f8400;fill-opacity:0.62745098;fill-rule:nonzero;stroke:none" /> style="fill:#3f8400;fill-opacity:0.62745098;fill-rule:nonzero;stroke:none" />
<rect
y="36.329243"
x="70"
height="20"
width="4"
id="hint-bar-size"
style="fill:#3f8400;fill-opacity:0.62745098;fill-rule:nonzero;stroke:none" />
<g <g
transform="translate(-240,-25)" transform="translate(-240,-25)"
id="bar-active-topleft"> id="bar-active-topleft">

Before

Width:  |  Height:  |  Size: 36 KiB

After

Width:  |  Height:  |  Size: 36 KiB

View File

@ -404,6 +404,13 @@
height="3.5355339" height="3.5355339"
x="37.653435" x="37.653435"
y="41.19239" /> y="41.19239" />
<rect
y="36.329243"
x="70"
height="20"
width="4"
id="hint-bar-size"
style="fill:#3f8400;fill-opacity:0.62745098;fill-rule:nonzero;stroke:none" />
<g <g
id="bar-inactive-top" id="bar-inactive-top"
transform="translate(17.942834,-17.67767)"> transform="translate(17.942834,-17.67767)">

Before

Width:  |  Height:  |  Size: 22 KiB

After

Width:  |  Height:  |  Size: 23 KiB