alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not reset model while changing the regexp

Browse Source 
There is no need to do so, QSortFilterProxyModel correctly adjust rows

REVIEW: 105042
This commit is contained in:
Aurélien Gâteau 2012-05-25 14:33:34 +02:00
parent f145e1de8e
commit 0ddb12cf96
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
declarativeimports/core/datamodel.cpp
View File

@ -82,12 +82,7 @@ void SortFilterModel::setModel(QObject *source)
void SortFilterModel::setFilterRegExp(const QString &exp) void SortFilterModel::setFilterRegExp(const QString &exp)
{ {
//FIXME: this delaying of the reset signal seems to make the views behave a bit better, i.e. less holes and avoids some crashes, in theory shouldn't be necessary
beginResetModel();
blockSignals(true);
QSortFilterProxyModel::setFilterRegExp(QRegExp(exp, Qt::CaseInsensitive)); QSortFilterProxyModel::setFilterRegExp(QRegExp(exp, Qt::CaseInsensitive));
blockSignals(false);
endResetModel();
} }
QString SortFilterModel::filterRegExp() const QString SortFilterModel::filterRegExp() const