alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[PlasmaComponents]Clean up ListItem code

Browse Source 
Summary:
Removed two unused lines.
Removed old comments.
Minor style changes to comments.

Test Plan: Everything must stay unchanged visually and function wise for ListItems.

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27296
This commit is contained in:
George Vogiatzis 2020-02-10 19:16:41 +02:00
parent 1e11099c16
commit 10c112fccd
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/declarativeimports/plasmacomponents/qml/ListItem.qml
View File

@ -32,12 +32,11 @@ Item {
default property alias content: paddingItem.data default property alias content: paddingItem.data
/** /**
* type:bool Holds if the item emits signals related to mouse interaction. * type: bool
* * True if the item emits signals related to mouse interaction.
* The default value is false. * The default value is false.
*/ */
property alias enabled: itemMouse.enabled property alias enabled: itemMouse.enabled
//item has been clicked or pressed+hold
/** /**
* This signal is emitted when there is a click. * This signal is emitted when there is a click.
@ -61,15 +60,12 @@ Item {
* If true makes the list item look as checked or pressed. It has to be set * If true makes the list item look as checked or pressed. It has to be set
* from the code, it won't change by itself. * from the code, it won't change by itself.
*/ */
//plasma extension
//always look pressed?
property bool checked: false property bool checked: false
/** /**
* If true the item will be a delegate for a section, so will look like a * If true the item will be a delegate for a section, so will look like a
* "title" for the otems under it. * "title" for the items under it.
*/ */
//is this to be used as section delegate?
property bool sectionDelegate: false property bool sectionDelegate: false
/** /**
@ -97,7 +93,6 @@ Item {
anchors.fill: parent anchors.fill: parent
visible: listItem.ListView.view ? listItem.ListView.view.highlight === null : true visible: listItem.ListView.view ? listItem.ListView.view.highlight === null : true
Behavior on opacity { NumberAnimation { duration: units.longDuration } }
} }
PlasmaCore.SvgItem { PlasmaCore.SvgItem {
svg: PlasmaCore.Svg {imagePath: "widgets/listitem"} svg: PlasmaCore.Svg {imagePath: "widgets/listitem"}
@ -113,7 +108,6 @@ Item {
MouseArea { MouseArea {
id: itemMouse id: itemMouse
property bool changeBackgroundOnPress: !listItem.checked && !listItem.sectionDelegate
anchors.fill: background anchors.fill: background
enabled: false enabled: false
hoverEnabled: true hoverEnabled: true