alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

package metadat by reference, not pointer, for API clarity and health

Browse Source 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=878840
This commit is contained in:
Aaron J. Seigo 2008-11-01 22:01:31 +00:00
parent 6b1c0f6c91
commit 1aa252d612
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package.cpp
View File

@ -177,13 +177,13 @@ QStringList Package::entryList(const char *fileType) const
return QStringList(); return QStringList();
} }
const PackageMetadata *Package::metadata() const PackageMetadata Package::metadata() const
{ {
//FIXME: this only works for native plasma packges; should fall back to... PackageStructure? //FIXME: this only works for native plasma packges; should fall back to... PackageStructure?
if (!d->metadata) { if (!d->metadata) {
d->metadata = new PackageMetadata(d->basePath + "metadata.desktop"); d->metadata = new PackageMetadata(d->basePath + "metadata.desktop");
} }
return d->metadata; return *d->metadata;
} }
const QString Package::path() const const QString Package::path() const

2
package.h
View File

@ -101,7 +101,7 @@ class PLASMA_EXPORT Package
/** /**
* @return the package metadata object. * @return the package metadata object.
*/ */
const PackageMetadata *metadata() const; PackageMetadata metadata() const;
/** /**
* @return the path to the root of this particular package * @return the path to the root of this particular package