From 34bed4571c7c80dd18b7a3cbdc83c21ff88c2110 Mon Sep 17 00:00:00 2001 From: Noah Davis Date: Wed, 26 Aug 2020 03:15:13 -0400 Subject: [PATCH] Reduce toolbutton margins to 4px This makes it so flat buttons can use 22px icons, but still be the same size as raised buttons --- src/desktoptheme/breeze/widgets/button.svg | 78 +++++++++++----------- 1 file changed, 40 insertions(+), 38 deletions(-) diff --git a/src/desktoptheme/breeze/widgets/button.svg b/src/desktoptheme/breeze/widgets/button.svg index fbeeeed89..bede6c628 100644 --- a/src/desktoptheme/breeze/widgets/button.svg +++ b/src/desktoptheme/breeze/widgets/button.svg @@ -318,101 +318,101 @@ - + - + - + - + - + - + - + - + - - - - - + + + + + - + - + - + - + - + - + - + - - - - + + + + - - + + - - - - - - - - - - + + + + + + + + + + normal hover focus @@ -429,8 +429,10 @@ NOTE: shadow, hover and focus (not focus-background) use negative margins! This behavior is implemented in at least the following files (please keep this up to date, fix the problem or find a better place to put this info): plasma-framework/src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml - -We should add support for a negative margins hint to FrameSvg and document it instead of requiring people to read source code in order to know these things. Unfortunately, not sure if we can change the code of ButtonShadow since it would break themes that rely on this undocumented behaviour. Maybe in KF6. +plasma-framework/src/declarativeimports/plasmacomponents3/private/ButtonHover.qml +plasma-framework/src/declarativeimports/plasmacomponents3/private/ButtonFocus.qml + +We should add support for a negative margins hint to FrameSvg and document it instead of requiring people to read source code in order to know these things. Unfortunately, not sure if we can change the code of ButtonShadow since it would break themes that rely on this undocumented behaviour. Maybe in KF6.