alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PackageStructure no longer does widget browser UI

Browse Source 
too many problems with this: device appropriateness, not all packages are widgets, requires PackageStructure to be a QObject, etc..
This commit is contained in:
Aaron Seigo 2011-07-13 20:27:12 +02:00
parent ad26497543
commit 41bb1efb74
3 changed files with 0 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packagestructure.cpp
View File

@ -762,12 +762,6 @@ bool PackageStructure::uninstallPackage(const QString &packageName, const QStrin
return true; return true;
} }
void PackageStructure::createNewWidgetBrowser(QWidget *parent)
{
Q_UNUSED(parent)
emit newWidgetBrowserFinished();
}
QString PackageStructure::defaultPackageRoot() const QString PackageStructure::defaultPackageRoot() const
{ {
return d->packageRoot; return d->packageRoot;

20
packagestructure.h
View File

@ -270,20 +270,6 @@ public:
*/ */
virtual bool uninstallPackage(const QString &packageName, const QString &packageRoot); virtual bool uninstallPackage(const QString &packageName, const QString &packageRoot);
/**
* When called, the package plugin should display a window to the user
* that they can use to browser, select and then install widgets supported by
* this package plugin with.
*
* The user interface may be an in-process dialog or an out-of-process application.
*
* When the process is complete, the newWidgetBrowserFinished() signal must be
* emitted.
*
* @param parent the parent widget to use for the widget
*/
virtual void createNewWidgetBrowser(QWidget *parent = 0);
/** /**
* @return the prefix paths inserted between the base path and content entries, in order of priority. * @return the prefix paths inserted between the base path and content entries, in order of priority.
* When searching for a file, all paths will be tried in order. * When searching for a file, all paths will be tried in order.
@ -317,12 +303,6 @@ public:
*/ */
bool allowExternalPaths() const; bool allowExternalPaths() const;
Q_SIGNALS:
/**
* Emitted when the new widget browser process completes.
*/
void newWidgetBrowserFinished();
protected: protected:
/** /**
* Sets whether or not external paths/symlinks can be followed by a package * Sets whether or not external paths/symlinks can be followed by a package

17
private/packages.cpp
View File

@ -81,9 +81,6 @@ PlasmoidPackage::PlasmoidPackage(QObject *parent)
PlasmoidPackage::~PlasmoidPackage() PlasmoidPackage::~PlasmoidPackage()
{ {
#ifndef PLASMA_NO_KNEWSTUFF
delete m_knsDialog.data();
#endif
} }
void PlasmoidPackage::pathChanged() void PlasmoidPackage::pathChanged()
@ -97,20 +94,6 @@ void PlasmoidPackage::pathChanged()
} }
} }
void PlasmoidPackage::createNewWidgetBrowser(QWidget *parent)
{
#ifndef PLASMA_NO_KNEWSTUFF
KNS3::DownloadDialog *knsDialog = m_knsDialog.data();
if (!knsDialog) {
m_knsDialog = knsDialog = new KNS3::DownloadDialog("plasmoids.knsrc", parent);
connect(knsDialog, SIGNAL(accepted()), this, SIGNAL(newWidgetBrowserFinished()));
}
knsDialog->show();
knsDialog->raise();
#endif
}
DataEnginePackage::DataEnginePackage(QObject *parent) DataEnginePackage::DataEnginePackage(QObject *parent)
: Plasma::PackageStructure(parent, QString("DataEngine")) : Plasma::PackageStructure(parent, QString("DataEngine"))
{ {