alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation

Browse Source 
Summary:
ListView.atYEnd is notoriously buggy and sometimes will cause indicators
to blink in and out of existence where not needed.

Reviewers: #plasma, mart

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D9089
This commit is contained in:
Eike Hein 2017-12-01 23:33:23 +09:00
parent fa3a389925
commit 4779f9564a
1 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/declarativeimports/plasmastyle/ScrollViewStyle.qml
View File

@ -72,12 +72,19 @@ QtQuickControlStyle.ScrollViewStyle {
}
PlasmaCore.SvgItem {
visible: {
if (flickableItem.hasOwnProperty("orientation")) {
return (flickableItem.orientation === Qt.Vertical);
}
return false;
}
svg: borderSvg
z: 1000
elementId: "border-top"
width: 100
height: naturalSize.height
opacity: flickableItem.atYBeginning ? 0 : 1
opacity: !visible || flickableItem.atYBeginning ? 0 : 1
Behavior on opacity {
NumberAnimation {
duration: units.longDuration
@ -91,12 +98,19 @@ QtQuickControlStyle.ScrollViewStyle {
}
}
PlasmaCore.SvgItem {
visible: {
if (flickableItem.hasOwnProperty("orientation")) {
return (flickableItem.orientation === Qt.Vertical);
}
return false;
}
svg: borderSvg
z: 1000
elementId: "border-bottom"
width: 100
height: naturalSize.height
opacity: flickableItem.atYEnd ? 0 : 1
opacity: !visible || flickableItem.atYEnd ? 0 : 1
Behavior on opacity {
NumberAnimation {
duration: units.longDuration
@ -110,11 +124,18 @@ QtQuickControlStyle.ScrollViewStyle {
}
}
PlasmaCore.SvgItem {
visible: {
if (flickableItem.hasOwnProperty("orientation")) {
return (flickableItem.orientation === Qt.Horizontal);
}
return false;
}
svg: borderSvg
z: 1000
elementId: "border-left"
width: naturalSize.width
opacity: flickableItem.atXBeginning ? 0 : 1
opacity: !visible || flickableItem.atXBeginning ? 0 : 1
Behavior on opacity {
NumberAnimation {
duration: units.longDuration
@ -128,11 +149,18 @@ QtQuickControlStyle.ScrollViewStyle {
}
}
PlasmaCore.SvgItem {
visible: {
if (flickableItem.hasOwnProperty("orientation")) {
return (flickableItem.orientation === Qt.Horizontal);
}
return false;
}
svg: borderSvg
z: 1000
elementId: "border-right"
width: naturalSize.width
opacity: flickableItem.atXEnd ? 0 : 1
opacity: !visible || flickableItem.atXEnd ? 0 : 1
Behavior on opacity {
NumberAnimation {
duration: units.longDuration