alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

assign d->target later or the comparison is always false, connect to

Browse Source 
destroyed and crash--

svn path=/trunk/KDE/kdelibs/; revision=1025756
This commit is contained in:
Marco Martin 2009-09-19 15:50:06 +00:00
parent efbe7150fd
commit 48fe7cee90
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
widgets/itembackground.cpp
View File

@ -139,8 +139,6 @@ void ItemBackground::setTargetItem(QGraphicsItem *target)
} }
if (target) { if (target) {
d->target = target;
setZValue(target->zValue() - 1); setZValue(target->zValue() - 1);
setParentItem(target->parentItem()); setParentItem(target->parentItem());
QRectF rect = target->boundingRect(); QRectF rect = target->boundingRect();
@ -148,7 +146,7 @@ void ItemBackground::setTargetItem(QGraphicsItem *target)
setTarget(rect); setTarget(rect);
if (d->target != target) { if (d->target != target) {
d->target->installSceneEventFilter(this); target->installSceneEventFilter(this);
QObject *obj = 0; QObject *obj = 0;
if (target->isWidget()) { if (target->isWidget()) {
@ -161,6 +159,7 @@ void ItemBackground::setTargetItem(QGraphicsItem *target)
connect(obj, SIGNAL(destroyed(QObject*)), this, SLOT(targetDestroyed(QObject*))); connect(obj, SIGNAL(destroyed(QObject*)), this, SLOT(targetDestroyed(QObject*)));
} }
} }
d->target = target;
} else { } else {
d->target = 0; d->target = 0;
hide(); hide();