alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix memory leak in ConfigView and Dialog

Browse Source 
Reviewers: #plasma, #frameworks, apol, davidedmundson

Reviewed By: apol, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23339
This commit is contained in:
Daniel Vrátil 2020-02-25 14:31:22 +01:00
parent 6b8f114284
commit 4b93b71a49
No known key found for this signature in database
GPG Key ID: 4D69557AECB13683
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plasmaquick/configview.cpp
View File

@ -53,7 +53,7 @@ class ConfigViewPrivate
{
public:
ConfigViewPrivate(Plasma::Applet *appl, ConfigView *view);
~ConfigViewPrivate();
~ConfigViewPrivate() = default;
void init();

3
src/plasmaquick/configview.h
View File

@ -21,6 +21,7 @@
#define CONFIGVIEW_H
#include <QQuickView>
#include <QScopedPointer>
#include <plasmaquick/plasmaquick_export.h>
@ -81,7 +82,7 @@ protected:
void resizeEvent(QResizeEvent *re) override;
private:
ConfigViewPrivate *const d;
QScopedPointer<ConfigViewPrivate> const d;
Q_PRIVATE_SLOT(d, void updateMinimumWidth())
Q_PRIVATE_SLOT(d, void updateMinimumHeight())

3
src/plasmaquick/dialog.h
View File

@ -24,6 +24,7 @@
#include <QQuickWindow>
#include <QPoint>
#include <QQmlParserStatus>
#include <QScopedPointer>
#include <Plasma/Plasma>
#include <Plasma/Theme>
@ -241,7 +242,7 @@ protected:
private:
friend class DialogPrivate;
DialogPrivate *const d;
const QScopedPointer<DialogPrivate> d;
Q_PRIVATE_SLOT(d, void updateInputShape())
Q_PRIVATE_SLOT(d, void updateTheme())