From 4ee2d5ca22a94f08e4900237a6ab314083fc47a1 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Fri, 12 Sep 2014 18:50:00 +0200 Subject: [PATCH] Fix binding loop in Toolbuttonstyle Setting the implcit width to be the same as the current height is very easy to end up looping. actual height of the background is set by the base style, which is based on the implicit sizes anyway. BUG: 338750 Change-Id: Ic7606588cec09c6ff16515c208efe576466d31d6 --- .../plasmacomponents/qml/styles/ToolButtonStyle.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml b/src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml index e484c9381..23714b3ed 100644 --- a/src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml +++ b/src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml @@ -170,7 +170,7 @@ QtQuickControlStyle.ButtonStyle { implicitWidth: { if (control.text.length == 0) { - height; + implicitHeight; } else { Math.max(theme.mSize(theme.defaultFont).width*12, style.minimumWidth); }