Don't make Headings 20% transparent, to match Kirigami

Summary:
We [[https://cgit.kde.org/kirigami.git/commit/?id=95417dc1f9bea79cabffb95fa0a79621167a6106|recently removed Kirigami Headings' slight transparency]], after concluding that it looked inappropriate to have Headings with lighter text than their textual content. `PlasmaExtras.Heading` does the same thing, so we should make the same change here, both based on the inherent merits of the change, and also to maintain consistency with Kirigami.

This also slightly improves matters for people who complain about poor text contrast throughout Plasma.

Test Plan:
Browsed System Settings; headings are now ever so slightly darker (or lighter, for users of Dark themes)

Also, here are some befores-and-afters for a widget I'm working on that uses Headings. Before:
{F5732641}

After:
{F5732643}

It's subtle; you'll need to flip between the two with the arrow keys to see the difference, and may need to also zoom in ({key meta +})

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D10899
This commit is contained in:
Nathaniel Graham 2018-02-27 11:56:12 -07:00
parent 3c5d6a9be8
commit 51d5f00920

View File

@ -64,7 +64,6 @@ Label {
font.pointSize: headerPointSize(level)
font.weight: Font.Light
wrapMode: Text.WordWrap
opacity: 0.8
function headerPointSize(l) {
var n = theme.defaultFont.pointSize;