alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid potential detach on range-loops with non-const Qt containers

Browse Source 
Seen by clazy range-loop
This commit is contained in:
Friedrich W. H. Kossebau 2018-09-18 01:11:28 +02:00
parent a73ac63ace
commit 53a2960353
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/plasma/private/theme_p.cpp
View File

@ -219,7 +219,8 @@ bool ThemePrivate::useCache()
QDir cacheDir(QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation)); QDir cacheDir(QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation));
cacheDir.setNameFilters(QStringList({cacheFileBase})); cacheDir.setNameFilters(QStringList({cacheFileBase}));
for (const QFileInfo &file : cacheDir.entryInfoList()) { const auto files = cacheDir.entryInfoList();
for (const QFileInfo &file : files) {
if (currentCacheFileName.isEmpty() || if (currentCacheFileName.isEmpty() ||
!file.absoluteFilePath().endsWith(currentCacheFileName)) { !file.absoluteFilePath().endsWith(currentCacheFileName)) {
QFile::remove(file.absoluteFilePath()); QFile::remove(file.absoluteFilePath());
@ -268,7 +269,8 @@ bool ThemePrivate::useCache()
QDir cacheDir(QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation)); QDir cacheDir(QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation));
cacheDir.setNameFilters(QStringList({svgElementsFileNameBase + QLatin1Char('*')})); cacheDir.setNameFilters(QStringList({svgElementsFileNameBase + QLatin1Char('*')}));
for (const QFileInfo &file : cacheDir.entryInfoList()) { const auto files = cacheDir.entryInfoList();
for (const QFileInfo &file : files) {
if (!file.absoluteFilePath().endsWith(svgElementsFileName)) { if (!file.absoluteFilePath().endsWith(svgElementsFileName)) {
QFile::remove(file.absoluteFilePath()); QFile::remove(file.absoluteFilePath());
} }