alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove minimum size test from PC3 Button test

Browse Source 
Also add disabled buttons to the PC3 Button test

The minimum size test didn't make any sense. You don't normally set the implicitWidth of a button to Layout.minimumWidth in a Layout.
This commit is contained in:
Noah Davis 2020-08-26 03:21:09 -04:00
parent 34bed4571c
commit 54069ee94c
1 changed files with 19 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
tests/components/button3.qml
View File

@ -66,6 +66,15 @@ ComponentBase {
Layout.maximumWidth: 150
}
PlasmaComponents.Label {
text: "disabled icon + text"
}
PlasmaComponents.Button {
icon.name: "start-here-kde-plasma"
text: "test"
enabled: false
}
PlasmaComponents.Label {
text: "button (with or without icon) and textfield should have the same height"
@ -83,26 +92,6 @@ ComponentBase {
}
}
PlasmaComponents.Label {
text: "minimum width property. Should be two letters wide"
}
RowLayout {
PlasmaComponents.Button {
text: "AA"
implicitWidth: Layout.minimumWidth
}
PlasmaComponents.Button {
icon.name: "application-menu"
text: "AA"
implicitWidth: Layout.minimumWidth
}
PlasmaComponents.Button {
icon.name: "application-menu"
implicitWidth: Layout.minimumWidth
}
}
PlasmaComponents.Label {
text: "Display property"
}
@ -186,6 +175,16 @@ ComponentBase {
flat: true
}
PlasmaComponents.Label {
text: "disabled icon + text"
}
PlasmaComponents.Button {
icon.name: "start-here-kde-plasma"
text: "test"
flat: true
enabled: false
}
PlasmaComponents.Label {
text: "button (with or without icon) and textfield should have the same height"
@ -205,29 +204,6 @@ ComponentBase {
}
}
PlasmaComponents.Label {
text: "minimum width property. Should be two letters wide"
}
RowLayout {
PlasmaComponents.Button {
text: "AA"
implicitWidth: Layout.minimumWidth
flat: true
}
PlasmaComponents.Button {
icon.name: "application-menu"
text: "AA"
implicitWidth: Layout.minimumWidth
flat: true
}
PlasmaComponents.Button {
icon.name: "application-menu"
implicitWidth: Layout.minimumWidth
flat: true
}
}
PlasmaComponents.Label {
text: "Display property"
}