Remove random qDebug output

Makes it easier to spot the actual problems on the output. If there's
something that's actually indicating a problem, we should make it a
qWarning.
This commit is contained in:
Aleix Pol 2014-05-06 19:57:31 +02:00
parent ac963b8a27
commit 556c1e321a
7 changed files with 6 additions and 19 deletions

View File

@ -375,10 +375,10 @@ void WindowThumbnail::resolveGLXFunctions()
auto *context = window()->openglContext(); auto *context = window()->openglContext();
QList<QByteArray> extensions = QByteArray(glXQueryExtensionsString(QX11Info::display(), QX11Info::appScreen())).split(' '); QList<QByteArray> extensions = QByteArray(glXQueryExtensionsString(QX11Info::display(), QX11Info::appScreen())).split(' ');
if (extensions.contains(QByteArrayLiteral("GLX_EXT_texture_from_pixmap"))) { if (extensions.contains(QByteArrayLiteral("GLX_EXT_texture_from_pixmap"))) {
qDebug() << "Have texture from pixmap";
m_bindTexImage = context->getProcAddress(QByteArrayLiteral("glXBindTexImageEXT")); m_bindTexImage = context->getProcAddress(QByteArrayLiteral("glXBindTexImageEXT"));
m_releaseTexImage = context->getProcAddress(QByteArrayLiteral("glXReleaseTexImageEXT")); m_releaseTexImage = context->getProcAddress(QByteArrayLiteral("glXReleaseTexImageEXT"));
} } else
qWarning() << "couldn't resolve GLX_EXT_texture_from_pixmap functions";
m_openGLFunctionsResolved = true; m_openGLFunctionsResolved = true;
} }

View File

@ -62,8 +62,6 @@ QString Application::application() const
void Application::setApplication(const QString &application) void Application::setApplication(const QString &application)
{ {
qDebug() << "setting the application to" << application;
// TODO: make an application whitelist // TODO: make an application whitelist
// and ensure those are invoked from the system // and ensure those are invoked from the system
// prefix (plasma's) // prefix (plasma's)
@ -71,8 +69,6 @@ void Application::setApplication(const QString &application)
return; return;
} }
qDebug() << "setting the application to" << application;
d->application = application; d->application = application;
emit applicationChanged(application); emit applicationChanged(application);
@ -84,7 +80,6 @@ void Application::setApplication(const QString &application)
void Application::setRunning(bool run) void Application::setRunning(bool run)
{ {
qDebug() << "running?" << run;
d->running = run; d->running = run;
if (run) { if (run) {
@ -105,7 +100,6 @@ void Application::start()
return; return;
} }
qDebug() << "Starting" << d->application;
d->process.start(d->application); d->process.start(d->application);
if (!d->process.waitForStarted()) { if (!d->process.waitForStarted()) {

View File

@ -33,12 +33,9 @@ public:
PlatformComponentsPlugin(QObject *parent = Q_NULLPTR) PlatformComponentsPlugin(QObject *parent = Q_NULLPTR)
: QQmlExtensionPlugin(parent) : QQmlExtensionPlugin(parent)
{ {
qDebug() << "instantiated plugin object";
} }
void registerTypes(const char *uri) Q_DECL_OVERRIDE { void registerTypes(const char *uri) Q_DECL_OVERRIDE {
qDebug() << "plugin loaded, registering types " << uri;
Q_ASSERT(QLatin1String(uri) == QLatin1String("org.kde.plasma.platformcomponents")); Q_ASSERT(QLatin1String(uri) == QLatin1String("org.kde.plasma.platformcomponents"));
qmlRegisterType<Application> (uri, 2, 0, "Application"); qmlRegisterType<Application> (uri, 2, 0, "Application");

View File

@ -540,7 +540,6 @@ QList<Plasma::Containment *> CoronaPrivate::importLayout(const KConfigGroup &con
QObject::connect(containment, &Plasma::Containment::uiReadyChanged, [ = ]() { QObject::connect(containment, &Plasma::Containment::uiReadyChanged, [ = ]() {
--containmentsStarting; --containmentsStarting;
if (containmentsStarting <= 0) { if (containmentsStarting <= 0) {
qDebug() << "Corona Startup Completed";
emit q->startupCompleted(); emit q->startupCompleted();
} }
}); });

View File

@ -72,7 +72,7 @@ void ViewPrivate::setContainment(Plasma::Containment *cont)
QObject::disconnect(containment.data(), 0, q, 0); QObject::disconnect(containment.data(), 0, q, 0);
QObject *oldGraphicObject = containment.data()->property("_plasma_graphicObject").value<QObject *>(); QObject *oldGraphicObject = containment.data()->property("_plasma_graphicObject").value<QObject *>();
if (oldGraphicObject) { if (oldGraphicObject) {
qDebug() << "Old graphics Object:" << oldGraphicObject << "Old containment" << containment.data(); // qDebug() << "Old graphics Object:" << oldGraphicObject << "Old containment" << containment.data();
//make sure the graphic object won't die with us //make sure the graphic object won't die with us
//FIXME:we need a way to reparent to *NO* graphics item, but this makes Qt crash //FIXME:we need a way to reparent to *NO* graphics item, but this makes Qt crash
oldGraphicObject->setParent(containment.data()); oldGraphicObject->setParent(containment.data());
@ -106,7 +106,7 @@ void ViewPrivate::setContainment(Plasma::Containment *cont)
QQuickItem *graphicObject = qobject_cast<QQuickItem *>(containment.data()->property("_plasma_graphicObject").value<QObject *>()); QQuickItem *graphicObject = qobject_cast<QQuickItem *>(containment.data()->property("_plasma_graphicObject").value<QObject *>());
if (graphicObject) { if (graphicObject) {
qDebug() << "using as graphic containment" << graphicObject << containment.data(); // qDebug() << "using as graphic containment" << graphicObject << containment.data();
//by resizing before adding, it will avoid some resizes in most cases //by resizing before adding, it will avoid some resizes in most cases
graphicObject->setProperty("width", q->width()); graphicObject->setProperty("width", q->width());

View File

@ -140,8 +140,6 @@ void AppletInterface::init()
AppletQuickItem::init(); AppletQuickItem::init();
qDebug() << "Graphic object created:" << applet() << this;
geometryChanged(QRectF(), QRectF(x(), y(), width(), height())); geometryChanged(QRectF(), QRectF(x(), y(), width(), height()));
emit busyChanged(); emit busyChanged();

View File

@ -131,7 +131,6 @@ void ContainmentInterface::init()
if (toolBoxObject) { if (toolBoxObject) {
containmentGraphicObject->setProperty("toolBox", QVariant::fromValue(toolBoxObject)); containmentGraphicObject->setProperty("toolBox", QVariant::fromValue(toolBoxObject));
} }
qDebug() << "Loaded toolbox package" << pkg.path();
} }
} else { } else {
qWarning() << "Could not load toolbox package." << pkg.path(); qWarning() << "Could not load toolbox package." << pkg.path();
@ -501,8 +500,8 @@ void ContainmentInterface::appletAddedForward(Plasma::Applet *applet)
QObject *appletGraphicObject = applet->property("_plasma_graphicObject").value<QObject *>(); QObject *appletGraphicObject = applet->property("_plasma_graphicObject").value<QObject *>();
QObject *contGraphicObject = containment()->property("_plasma_graphicObject").value<QObject *>(); QObject *contGraphicObject = containment()->property("_plasma_graphicObject").value<QObject *>();
qDebug() << "Applet added on containment:" << containment()->title() << contGraphicObject // qDebug() << "Applet added on containment:" << containment()->title() << contGraphicObject
<< "Applet: " << applet << applet->title() << appletGraphicObject; // << "Applet: " << applet << applet->title() << appletGraphicObject;
if (!appletGraphicObject) { if (!appletGraphicObject) {
appletGraphicObject = new AppletInterface(applet, QVariantList(), this); appletGraphicObject = new AppletInterface(applet, QVariantList(), this);