From 6755a8f3091408c9a4efae30b5b4e535e420b777 Mon Sep 17 00:00:00 2001 From: "Aaron J. Seigo" Date: Mon, 11 May 2009 23:52:25 +0000 Subject: [PATCH] now that we use plasmapkg via knewstuff to do the installation, we shouldn't try and repeat the trick ourselves afterwards. it gives the illusion that packages aren't installed when they really are. BUG:187436 svn path=/trunk/KDE/kdelibs/; revision=966843 --- private/packages.cpp | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/private/packages.cpp b/private/packages.cpp index 1616cdb63..878c599c6 100644 --- a/private/packages.cpp +++ b/private/packages.cpp @@ -81,22 +81,8 @@ void PlasmoidPackage::createNewWidgetBrowser(QWidget *parent) { KNS::Engine engine(0); if (engine.init("plasmoids.knsrc")) { + //FIXME: this should not be modal, but requires fixes in knewstuff2 first KNS::Entry::List entries = engine.downloadDialogModal(parent); - - foreach (KNS::Entry *entry, entries) { - if (entry->status() != KNS::Entry::Installed) { - continue; - } - - // install the packges! - foreach (const QString &package, entry->installedFiles()) { - if (!installPackage(package, defaultPackageRoot())) { - kDebug() << "FAIL! on install of" << package; - KMessageBox::error(0, i18n("Installation of %1 failed.", package), - i18n("Installation Failed")); - } - } - } } emit newWidgetBrowserFinished();