never reparent old mainItems

This is not completely correct.
however, when reparenting the mainItem containming window thumbnails
it causes serious graphical artifacts, like the "lost fonts" on
nvidia and fglrx

Change-Id: Id194f5e7863e4ed71792835a9a3cf9c6e4fa70ee
This commit is contained in:
Marco Martin 2014-10-08 14:32:52 +02:00
parent 9796f043b7
commit 68eadae6c8

View File

@ -122,7 +122,6 @@ public:
Plasma::FrameSvgItem *frameSvgItem;
QPointer<QQuickItem> mainItem;
QPointer<QQuickItem> visualParent;
QPointer<QQuickItem> oldMainItemParent;
QTimer hintsCommitTimer;
QRect cachedGeometry;
@ -635,13 +634,13 @@ void Dialog::setMainItem(QQuickItem *mainItem)
if (d->mainItem != mainItem) {
d->hintsCommitTimer.stop();
if (d->mainItem) {
d->mainItem->setParentItem(d->oldMainItemParent);
d->mainItem->setVisible(false);
}
d->mainItem = mainItem;
if (mainItem) {
d->oldMainItemParent = mainItem->parentItem();
d->mainItem->setVisible(true);
mainItem->setParentItem(contentItem());
connect(mainItem, SIGNAL(widthChanged()), this, SLOT(slotMainItemSizeChanged()));