alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

get rid of the redundant jobFinished signal in Service

Browse Source 
it's a bitch for bindings as well
This commit is contained in:
Aaron Seigo 2011-06-03 13:16:35 +02:00
parent fa61d11d3c
commit 69e9b84371
3 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
private/service_p.h
View File

@ -92,8 +92,6 @@ public:
delete dummyConfig;
}
void jobFinished(KJob *job);
void associatedWidgetDestroyed(QObject *obj);
void associatedGraphicsWidgetDestroyed(QObject *obj);

6
service.cpp
View File

@ -80,11 +80,6 @@ Service *Service::access(const KUrl &url, QObject *parent)
return new RemoteService(parent, url);
}
void ServicePrivate::jobFinished(KJob *job)
{
emit q->finished(static_cast<ServiceJob*>(job));
}
void ServicePrivate::associatedWidgetDestroyed(QObject *obj)
{
associatedWidgets.remove(static_cast<QWidget*>(obj));
@ -244,7 +239,6 @@ ServiceJob *Service::startOperationCall(const KConfigGroup &description, QObject
}
job->setParent(parent ? parent : this);
connect(job, SIGNAL(finished(KJob*)), this, SLOT(jobFinished(KJob*)));
QTimer::singleShot(0, job, SLOT(autoStart()));
return job;
}

6
service.h
View File

@ -229,11 +229,6 @@ public:
Q_INVOKABLE QHash<QString, QVariant> parametersFromDescription(const KConfigGroup &description);
Q_SIGNALS:
/**
* Emitted when a job associated with this Service completes its task
*/
void finished(Plasma::ServiceJob *job);
/**
* Emitted when the Service's operations change. For example, a
* media player service may change what operations are available
@ -300,7 +295,6 @@ protected:
void setOperationEnabled(const QString &operation, bool enable);
private:
Q_PRIVATE_SLOT(d, void jobFinished(KJob *))
Q_PRIVATE_SLOT(d, void associatedWidgetDestroyed(QObject *))
Q_PRIVATE_SLOT(d, void associatedGraphicsWidgetDestroyed(QObject *))