From 6af447a848677a0b90fa714a30b8fead5f05fa6b Mon Sep 17 00:00:00 2001 From: "Friedrich W. H. Kossebau" Date: Mon, 13 May 2019 01:56:20 +0200 Subject: [PATCH] FrameSvgPrivate::generateBackground: generate background also if reqp != p Summary: d8a1a9eb084b19e552c789244267f7346e1b27a8 changed the condition from hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix) but it is not clear why, as the background is generated from the prefix data & the requestedPrefix is no-where in effect. As a result sometimes the background is not rendered for a given not-existing requestedPrefix which was mapped to an empty prefix instead. Reviewers: #plasma, mart Reviewed By: #plasma, mart Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D21175 --- src/plasma/framesvg.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plasma/framesvg.cpp b/src/plasma/framesvg.cpp index b53bee0cd..a95ba0f88 100644 --- a/src/plasma/framesvg.cpp +++ b/src/plasma/framesvg.cpp @@ -452,7 +452,7 @@ QSharedPointer FrameSvgPrivate::lookupOrCreateMaskFrame(const QShared void FrameSvgPrivate::generateBackground(const QSharedPointer &frame) { - if (!frame->cachedBackground.isNull() || !q->hasElementPrefix(frame->requestedPrefix)) { + if (!frame->cachedBackground.isNull() || !q->hasElementPrefix(frame->prefix)) { return; }