alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

close the strage db when the job is over.

Browse Source 
there were dangling file pointers before that could crash plasma when they go beyond the maximum allowed limit
BUG:259833
CCBUG:247798
BUG:235051


svn path=/trunk/KDE/kdelibs/; revision=1212407
This commit is contained in:
Marco Martin 2011-01-06 21:43:51 +00:00
parent 54ad0622e7
commit 6d042ac25a
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
private/storage.cpp
View File

@ -85,7 +85,6 @@ void StorageJob::start()
query.bindValue(":datavalue", params["data"]); query.bindValue(":datavalue", params["data"]);
const bool success = query.exec(); const bool success = query.exec();
setResult(success); setResult(success);
return;
} else if (operationName() == "retrieve") { } else if (operationName() == "retrieve") {
QSqlQuery query(m_db); QSqlQuery query(m_db);
@ -124,9 +123,6 @@ void StorageJob::start()
} }
setResult(h); setResult(h);
return;
} else {
return;
} }
} else if (operationName() == "delete") { } else if (operationName() == "delete") {
@ -165,6 +161,9 @@ void StorageJob::start()
} else { } else {
setError(true); setError(true);
} }
//TODO: use a single shared db per thread
m_db.close();
QSqlDatabase::removeDatabase(m_db.connectionName());
} }
Plasma::ServiceJob* Storage::createJob(const QString &operation, QMap<QString, QVariant> &parameters) Plasma::ServiceJob* Storage::createJob(const QString &operation, QMap<QString, QVariant> &parameters)