From 70985897bb81ce0351d232ef590ee103f045e77f Mon Sep 17 00:00:00 2001 From: Anne-Marie Mahfouf Date: Thu, 24 Apr 2008 13:09:21 +0000 Subject: [PATCH] =?UTF-8?q?API=20review:=20DataContainer=20SIGNAL=20reques?= =?UTF-8?q?tUpdate()->updateRequested()=20Not=20used=20anywhere=20outside?= =?UTF-8?q?=20libs/plasma,=20not=20used=20in=20/extragear/plasma=20or=20/p?= =?UTF-8?q?layground/base/plasma=20Same=20case=20as=20SIGNAL=20unused()->b?= =?UTF-8?q?ecameUnused()=20as=20K=C3=A9vin=20noted,=20can=20be=20moved=20t?= =?UTF-8?q?o=20pimpl=20of=20DataContainer?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800587 --- datacontainer.h | 2 +- datacontainer_p.h | 2 +- dataengine.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/datacontainer.h b/datacontainer.h index 5e9ff3973..880b322de 100644 --- a/datacontainer.h +++ b/datacontainer.h @@ -144,7 +144,7 @@ class PLASMA_EXPORT DataContainer : public QObject * Emitted when the source, usually due to an internal timer firing, * requests to be updated. **/ - void requestUpdate(DataContainer *source); + void updateRequested(DataContainer *source); private: friend class SignalRelay; diff --git a/datacontainer_p.h b/datacontainer_p.h index dedca3ade..402fb0c33 100644 --- a/datacontainer_p.h +++ b/datacontainer_p.h @@ -146,7 +146,7 @@ protected: checkAlignment(); } - emit dc->requestUpdate(dc); + emit dc->updateRequested(dc); if (!dc->hasUpdates()) { // the source wasn't actually updated; so let's put ourselves in the queue // so we get an dataUpdated() when the data does arrive diff --git a/dataengine.cpp b/dataengine.cpp index 0a814f95e..5792d3c09 100644 --- a/dataengine.cpp +++ b/dataengine.cpp @@ -116,7 +116,7 @@ class DataEngine::Private DataContainer* s = new DataContainer(engine); s->setObjectName(sourceName); sources.insert(sourceName, s); - connect(s, SIGNAL(requestUpdate(DataContainer*)), engine, SLOT(internalUpdateSource(DataContainer*))); + connect(s, SIGNAL(updateRequested(DataContainer*)), engine, SLOT(internalUpdateSource(DataContainer*))); if (limit > 0) { trimQueue();