alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use more appropriate "Alternatives" icon and text

Browse Source 
Summary:
The new icon was just added in D20367. The current icon is semantically and visually incorrect,
and the new one fixes that.

The current text also does not begin with an action verb, and this patch fixes that too.

Test Plan:
Before:
{F6759646, size=full}

After:
{F6759647, size=full}
{F6759649, size=full}

Reviewers: #vdg, #plasma, GB_2, filipf

Reviewed By: #vdg, GB_2, filipf

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20392
This commit is contained in:
Nate Graham 2019-04-08 14:05:22 -06:00
parent f20722fbe1
commit 7687ffa3da
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plasma/private/applet_p.cpp
View File

@ -184,7 +184,7 @@ void AppletPrivate::init(const QString &_packagePath, const QVariantList &args)
} }
if (!q->isContainment()) { if (!q->isContainment()) {
QAction *a = new QAction(QIcon::fromTheme(QStringLiteral("preferences-desktop-default-applications")), i18n("Alternatives..."), q); QAction *a = new QAction(QIcon::fromTheme(QStringLiteral("widget-alternatives")), i18n("Show Alternatives..."), q);
a->setVisible(false); a->setVisible(false);
q->actions()->addAction(QStringLiteral("alternatives"), a); q->actions()->addAction(QStringLiteral("alternatives"), a);
QObject::connect(a, &QAction::triggered, [this] { QObject::connect(a, &QAction::triggered, [this] {