From 78f83f5c77449384731b1fa9f0784d80b866d921 Mon Sep 17 00:00:00 2001 From: Eike Hein Date: Tue, 5 Dec 2017 20:43:09 +0900 Subject: [PATCH] Don't set a window icon in Plasma::Dialog Summary: Setting a window icon is costly enough to be worth avoiding when it's not actually needed. This is a resurrection of David's old patch: https://git.reviewboard.kde.org/r/128484/ The concerns in the old discussion that led to its rejection are no longer valid today: In the meantime we implemented a way for apps to announce their .desktop file in a window hint, which KWin (and libtm) will fall back to to look up an icon if not set. As plasmashell does this, we can drop the setIcon call here and won't regress. Test Plan: The pinned systray popup dialog still gets the Plasma icon in the Present Windows effect. Reviewers: #plasma, #frameworks, davidedmundson, graesslin Subscribers: plasma-devel Tags: #plasma, #frameworks Differential Revision: https://phabricator.kde.org/D9209 --- src/plasmaquick/dialog.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp index e9ba73e44..a7bcd35fc 100644 --- a/src/plasmaquick/dialog.cpp +++ b/src/plasmaquick/dialog.cpp @@ -738,8 +738,6 @@ Dialog::Dialog(QQuickItem *parent) setColor(QColor(Qt::transparent)); setFlags(Qt::FramelessWindowHint | Qt::Dialog); - setIcon(QIcon::fromTheme(QStringLiteral("plasma"))); - connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); }); connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); });