alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix Plasma ScrollBar flickableItem position binding when mouse or keys are used

Browse Source 
The RangeModel value was being incremented directly by the mouse and keys
events, and it was overriding the binding with the flickableItem position.
Once the ScrollBar button was clicked, the direct manipulation of the
flickable component was not updating the scroll position.

The new function 'incrementValue' now does the correct work.

Signed-off-by: Daker Fernandes Pinheiro <dakerfp@gmail.com>
This commit is contained in:
Daker Fernandes Pinheiro 2011-07-15 10:03:17 -03:00
parent cba7e6204a
commit 8a3162b431
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
declarativeimports/plasmacomponents/ScrollBar.qml
View File

@ -41,21 +41,30 @@ Item {
property bool _showButtons: stepSize != 0
property bool _inverted: _isVertical ?
!scrollbar.inverted : scrollbar.inverted
property alias _value: range.value
implicitWidth: _isVertical ? 22 : 200
implicitHeight: _isVertical ? 200 : 22
visible: flickableItem && handle.width < contents.width
function incrementValue(increment) {
if (!flickableItem)
return;
if (_isVertical)
flickableItem.contentY += increment;
else
flickableItem.contentX += increment;
}
Keys.onUpPressed: {
if (!_isVertical)
return;
if (_inverted)
range.value -= stepSize;
incrementValue(-stepSize);
else
range.value += stepSize;
incrementValue(stepSize);
}
Keys.onDownPressed: {
@ -63,9 +72,9 @@ Item {
return;
if (_inverted)
range.value += stepSize;
incrementValue(stepSize);
else
range.value -= stepSize;
incrementValue(-stepSize);
}
Keys.onLeftPressed: {
@ -73,9 +82,9 @@ Item {
return;
if (_inverted)
range.value += stepSize;
incrementValue(stepSize);
else
range.value -= stepSize;
incrementValue(-stepSize);
}
Keys.onRightPressed: {
@ -83,9 +92,9 @@ Item {
return;
if (_inverted)
range.value -= stepSize;
incrementValue(-stepSize);
else
range.value += stepSize;
incrementValue(stepSize);
}
@ -133,9 +142,9 @@ Item {
onTriggered: {
scrollbar.forceActiveFocus();
if (_inverted)
_value += stepSize;
incrementValue(stepSize);
else
_value -= stepSize;
incrementValue(-stepSize);
}
}
}
@ -173,9 +182,9 @@ Item {
onTriggered: {
scrollbar.forceActiveFocus();
if (_inverted)
_value -= stepSize
incrementValue(-stepSize);
else
_value += stepSize;
incrementValue(stepSize);
}
}
}
@ -220,7 +229,6 @@ Item {
}
position: handle.x
onPositionChanged: { handle.x = position; }
}
PlasmaCore.FrameSvgItem {