From 8c443f504fc14dc02c55c367c3b264d617750369 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Tue, 18 May 2021 07:52:21 -0600 Subject: [PATCH] Filter configure action out of overflow menu correctly This code was trying to filter out the configure action but failing because it was comparing a QMenuItem to a QAction. We need to compare the QMenuItem's internal QAction in order for the configure action to ever match. Companion to 827afc3fc276d0d73b4e4d2f08e26c24a3e6ea71 in plasma-workspace. --- .../plasmaextracomponents/qml/BasicPlasmoidHeading.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/declarativeimports/plasmaextracomponents/qml/BasicPlasmoidHeading.qml b/src/declarativeimports/plasmaextracomponents/qml/BasicPlasmoidHeading.qml index 4cf36b48d..3a3dd5de3 100644 --- a/src/declarativeimports/plasmaextracomponents/qml/BasicPlasmoidHeading.qml +++ b/src/declarativeimports/plasmaextracomponents/qml/BasicPlasmoidHeading.qml @@ -112,7 +112,7 @@ PlasmoidHeading { action: modelData } onObjectAdded: { - if (object !== plasmoid.action("configure")) { + if (object.action !== plasmoid.action("configure")) { configMenu.addMenuItem(object); } }