alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

prevent save of not loaded modules

Browse Source 
BUG:301507
This commit is contained in:
Marco Martin 2012-06-19 20:05:06 +02:00
parent 1dfcd5369c
commit 977f1aceeb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
applet.cpp
View File

@ -1922,6 +1922,8 @@ void Applet::showConfigurationInterface()
#ifndef PLASMA_NO_KUTILS #ifndef PLASMA_NO_KUTILS
KCModuleProxy *module = new KCModuleProxy(kcm); KCModuleProxy *module = new KCModuleProxy(kcm);
if (module->realModule()) { if (module->realModule()) {
//preemptively load modules to prevent save() crashing on some kcms, like powerdevil ones
module->load();
connect(module, SIGNAL(changed(bool)), dialog, SLOT(settingsModified(bool))); connect(module, SIGNAL(changed(bool)), dialog, SLOT(settingsModified(bool)));
connect(dialog, SIGNAL(okClicked()), connect(dialog, SIGNAL(okClicked()),
module->realModule(), SLOT(save())); module->realModule(), SLOT(save()));
@ -1938,6 +1940,7 @@ void Applet::showConfigurationInterface()
QString error; QString error;
KCModule *module = service->createInstance<KCModule>(dialog, QVariantList(), &error); KCModule *module = service->createInstance<KCModule>(dialog, QVariantList(), &error);
if (module) { if (module) {
module->load();
connect(module, SIGNAL(changed(bool)), dialog, SLOT(settingsModified(bool))); connect(module, SIGNAL(changed(bool)), dialog, SLOT(settingsModified(bool)));
connect(dialog, SIGNAL(okClicked()), connect(dialog, SIGNAL(okClicked()),
module, SLOT(save())); module, SLOT(save()));