From 9d2a2e40bacf9adfe59ac6339b4756d4aa75f549 Mon Sep 17 00:00:00 2001
From: Chani Armitage <chanika@gmail.com>
Date: Mon, 17 Aug 2009 22:30:50 +0000
Subject: [PATCH] api review part 1

removed some dead signals and an unnecessary const

svn path=/trunk/KDE/kdelibs/; revision=1012640
---
 applet.h          |  2 +-
 containment.cpp   |  4 ----
 contextaction.cpp |  1 -
 contextaction.h   | 18 ------------------
 4 files changed, 1 insertion(+), 24 deletions(-)

diff --git a/applet.h b/applet.h
index e2c706976..4905c8697 100644
--- a/applet.h
+++ b/applet.h
@@ -702,7 +702,7 @@ class PLASMA_EXPORT Applet : public QGraphicsWidget
          * Emitted when the immutability changes
          * @since 4.4
          */
-        void immutabilityChanged(const ImmutabilityType immutable);
+        void immutabilityChanged(ImmutabilityType immutable);
 
     public Q_SLOTS:
         /**
diff --git a/containment.cpp b/containment.cpp
index 072a5d744..f7aef68a7 100644
--- a/containment.cpp
+++ b/containment.cpp
@@ -258,8 +258,6 @@ void Containment::init()
             ContextAction *action = ContextAction::load(defaults.value(trigger));
             if (action) {
                 d->contextActions.insert(trigger, action);
-                connect(action, SIGNAL(configureRequested()), this, SLOT(requestConfiguration()));
-                connect(action, SIGNAL(configNeedsSaving()), this, SIGNAL(configNeedsSaving()));
                 action->setParent(this);
             }
         }
@@ -1721,8 +1719,6 @@ void Containment::setContextAction(const QString &trigger, const QString &plugin
             if (action) {
                 cfg.writeEntry(trigger, pluginName);
                 d->contextActions.insert(trigger, action);
-                connect(action, SIGNAL(configureRequested()), this, SLOT(requestConfiguration()));
-                connect(action, SIGNAL(configNeedsSaving()), this, SIGNAL(configNeedsSaving()));
             } else {
                 //bad plugin... gets removed. is this a feature or a bug?
                 cfg.deleteEntry(trigger);
diff --git a/contextaction.cpp b/contextaction.cpp
index 6347f8d2d..799c580f5 100644
--- a/contextaction.cpp
+++ b/contextaction.cpp
@@ -231,7 +231,6 @@ void ContextAction::setConfigurationRequired(bool needsConfig, const QString &re
     }
 
     d->needsConfig = needsConfig;
-    emit configurationRequired(needsConfig);
 }
 
 } // Plasma namespace
diff --git a/contextaction.h b/contextaction.h
index e3b21ebb5..eec9c68bf 100644
--- a/contextaction.h
+++ b/contextaction.h
@@ -208,24 +208,6 @@ class PLASMA_EXPORT ContextAction : public QObject
          */
         QAction *configurationAction();
 
-    Q_SIGNALS:
-        /**
-         * Emitted when the user wants to configure/change the contextaction.
-         */
-        void configureRequested();
-
-        /**
-         * Emitted when the state of the contextaction requiring configuration
-         * changes.
-         */
-        void configurationRequired(bool needsConfig);
-
-        /**
-         * Emitted when the configuration of the contextaction needs to be saved
-         * to disk.
-         */
-        void configNeedsSaving();
-
     protected:
         /**
          * This constructor is to be used with the plugin loading systems