From a968892ba9d5a6c2fbd7c81b077a461a1f0ee676 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Fri, 25 Aug 2017 10:21:49 +0100 Subject: [PATCH] Guard failed testItem creation Summary: createObjectFromSource can return a null on error. This needs guarding. Reviewers: #plasma, mart Reviewed By: #plasma, mart Subscribers: plasma-devel, #frameworks Tags: #plasma, #frameworks Differential Revision: https://phabricator.kde.org/D7532 --- src/plasmaquick/appletquickitem.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plasmaquick/appletquickitem.cpp b/src/plasmaquick/appletquickitem.cpp index 4589f2087..7210e549a 100644 --- a/src/plasmaquick/appletquickitem.cpp +++ b/src/plasmaquick/appletquickitem.cpp @@ -676,7 +676,9 @@ QObject *AppletQuickItem::testItem() } d->testItem = d->qmlObject->createObjectFromSource(url, QtQml::qmlContext(rootItem())); - d->testItem->setProperty("plasmoidItem", QVariant::fromValue(this)); + if (d->testItem) { + d->testItem->setProperty("plasmoidItem", QVariant::fromValue(this)); + } } return d->testItem;