From adb9998988427b836456e5dafbe910cacb4d3c26 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Thu, 30 May 2019 10:38:54 -0600 Subject: [PATCH] [PlasmaComponents3] Vertically center button text as well Summary: The PC3 Button's Label didn't have `Layout.FillHeight: true` set, so button text was not actually getting vertically centered in certain circumstances. This patch fixes that. Found while working on D21503. Test Plan: Before: {F6860487, size=full} After: {F6860486, size=full} Reviewers: #plasma, broulik Reviewed By: #plasma, broulik Subscribers: broulik, apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D21502 --- src/declarativeimports/plasmacomponents3/Button.qml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/declarativeimports/plasmacomponents3/Button.qml b/src/declarativeimports/plasmacomponents3/Button.qml index 410aeb9ea..b7e7df40d 100644 --- a/src/declarativeimports/plasmacomponents3/Button.qml +++ b/src/declarativeimports/plasmacomponents3/Button.qml @@ -53,6 +53,7 @@ T.Button { } Label { Layout.fillWidth: !icon.visible + Layout.fillHeight: true visible: text.length > 0 text: control.Kirigami.MnemonicData.richTextLabel font: control.font