From b1364fa601866792ecf69cf61b8ab48732150857 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Thu, 17 Dec 2020 12:41:38 +0000 Subject: [PATCH] Fix broken background In commit c709076d9c52cbd177de18b3f199917f32d416dc the SVG got somehow broken leading to black rectangles in all cases where it was used. This commit reverts to the last working version, then reapplies the "thick margin" from the change. A test is supplied to show all our frameSVGs to hopefully make this easier to spot if it happens again. BUG: 430390 --- .../opaque/widgets/panel-background.svg | 500 +++++++++++++++--- tests/frames.qml | 41 ++ 2 files changed, 461 insertions(+), 80 deletions(-) create mode 100644 tests/frames.qml diff --git a/src/desktoptheme/breeze/opaque/widgets/panel-background.svg b/src/desktoptheme/breeze/opaque/widgets/panel-background.svg index 4936edc46..a3e5c85a0 100644 --- a/src/desktoptheme/breeze/opaque/widgets/panel-background.svg +++ b/src/desktoptheme/breeze/opaque/widgets/panel-background.svg @@ -1,6 +1,25 @@ - - - + + + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tests/frames.qml b/tests/frames.qml new file mode 100644 index 000000000..e908a4f31 --- /dev/null +++ b/tests/frames.qml @@ -0,0 +1,41 @@ +/* + SPDX-FileCopyrightText: 2020 David Edmundson + + SPDX-License-Identifier: LGPL-2.0-or-later +*/ + + +import QtQuick 2.0 +import QtQuick.Layouts 1.1 +import QtQuick.Controls 1.1 + +import org.kde.plasma.core 2.0 as PlasmaCore + +Item +{ + width: 500 + height: 500 + + + + Grid { + anchors.fill: parent + columns: 3 + + Repeater { + model: ["widgets/background", + "widgets/panel-background", + "opaque/widgets/panel-background", + "widgets/tooltip", + "opaque/widgets/tooltip" + ] + + delegate: PlasmaCore.FrameSvgItem { + width: 100 + height: 100 + imagePath: modelData + } + } + } +} +